From: Daiki Ueno <ueno@gnu.org>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: Mark Oteiza <mvoteiza@udel.edu>, Paul Eggert <eggert@cs.ucla.edu>,
22440@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#22440: 25.1.50; package.el fails to install with package-check-signature t
Date: Thu, 19 May 2016 10:30:08 +0900 [thread overview]
Message-ID: <m3lh36vnq7.fsf-ueno@gnu.org> (raw)
In-Reply-To: <87k2ir6u1b.fsf@gmail.com> (Artur Malabarba's message of "Wed, 18 May 2016 16:33:04 -0300")
Artur Malabarba <bruce.connor.am@gmail.com> writes:
> Here's a proposed fix.
Thank you for taking a look at this, the patch looks good to me.
> ;;;###autoload
> @@ -1558,12 +1558,8 @@ package-refresh-contents
> (let ((default-keyring (expand-file-name "package-keyring.gpg"
> data-directory))
> (inhibit-message async))
> - (if (get 'package-check-signature 'saved-value)
> - (when package-check-signature
> - (epg-find-configuration 'OpenPGP))
> - (setq package-check-signature
> - (if (epg-find-configuration 'OpenPGP)
> - 'allow-unsigned)))
> + (when package-check-signature
> + (epg-find-configuration 'OpenPGP))
While it was from the original code, I would suggest to check the return
value of `epg-find-configuration' or simply remove this `when' clause.
Regards,
--
Daiki Ueno
next prev parent reply other threads:[~2016-05-19 1:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 0:48 bug#22440: 25.1.50; package.el fails to install with package-check-signature t Mark Oteiza
2016-05-15 7:03 ` Paul Eggert
2016-05-15 11:32 ` Dmitry Gutov
2016-05-15 16:50 ` Paul Eggert
2016-05-16 10:59 ` Artur Malabarba
2016-05-18 13:50 ` Artur Malabarba
2016-05-18 16:29 ` Mark Oteiza
2016-05-18 16:36 ` Dmitry Gutov
2016-05-18 16:44 ` Mark Oteiza
2016-05-18 18:10 ` Paul Eggert
2016-05-18 18:23 ` Dmitry Gutov
2016-05-18 19:24 ` Artur Malabarba
2016-05-18 19:33 ` Artur Malabarba
2016-05-19 1:30 ` Daiki Ueno [this message]
2016-05-18 19:43 ` Artur Malabarba
2016-05-18 20:43 ` Artur Malabarba
2016-05-18 21:09 ` Artur Malabarba
2016-05-18 22:05 ` Paul Eggert
2016-05-18 23:11 ` Artur Malabarba
2016-05-19 15:15 ` Paul Eggert
2016-05-19 4:39 ` Lizzie Dixon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3lh36vnq7.fsf-ueno@gnu.org \
--to=ueno@gnu.org \
--cc=22440@debbugs.gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=dgutov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=mvoteiza@udel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.