From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36324: 27.0.50; Error in savehist-save: (wrong-type-argument listp t) Date: Sat, 22 Jun 2019 11:33:32 +0200 Message-ID: References: <87zhma9b6v.fsf@web.de> <87h88ir09w.fsf@web.de> <87lfxuxs76.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="109604"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36324@debbugs.gnu.org, Davor Rotim To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 22 11:34:37 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hecPs-000SGb-U0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Jun 2019 11:34:37 +0200 Original-Received: from localhost ([::1]:39640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hecPr-0005YD-Uh for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Jun 2019 05:34:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59312) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hecPL-0005Wg-CL for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 05:34:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hecPK-0004he-8M for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 05:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37441) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hecPK-0004hU-54 for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 05:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hecPJ-0004nY-V3 for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 05:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2019 09:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36324 X-GNU-PR-Package: emacs Original-Received: via spool by 36324-submit@debbugs.gnu.org id=B36324.156119602218418 (code B ref 36324); Sat, 22 Jun 2019 09:34:01 +0000 Original-Received: (at 36324) by debbugs.gnu.org; 22 Jun 2019 09:33:42 +0000 Original-Received: from localhost ([127.0.0.1]:50985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hecOz-0004n0-Ra for submit@debbugs.gnu.org; Sat, 22 Jun 2019 05:33:42 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:36612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hecOx-0004mr-AE for 36324@debbugs.gnu.org; Sat, 22 Jun 2019 05:33:40 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hecOq-0004KU-S5; Sat, 22 Jun 2019 11:33:35 +0200 In-Reply-To: <87lfxuxs76.fsf@web.de> (Michael Heerdegen's message of "Sat, 22 Jun 2019 04:35:41 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160973 Archived-At: Michael Heerdegen writes: > Though ... > >> > read-string("Confirm password: " nil t nil) > > Is it officially allowed to use t as histvar arg? It doesn't seem to be > documented. Yup; this is the way to reproduce the bug simply (with the patch unreverted): (savehist-mode) (read-string "foo" nil t) (savehist-save t) I've now reapplied the patch, but restored the t check in the hook and updated the comment. The doc string for `read-from-minibuffer' doesn't document the t value for HISTORY at all -- perhaps that should also be fixed? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no