From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34233: 27.0.50; defvar in comment Date: Thu, 11 Jul 2019 15:45:24 +0200 Message-ID: References: <87o923qdrm.fsf@mouse.gnus.org> <875zobdowo.fsf@web.de> <87y3161548.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="54173"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Michael Heerdegen , 34233@debbugs.gnu.org, Sebastian Miele , Stefan Monnier To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 11 15:46:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlZOt-000DwK-Qk for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jul 2019 15:46:19 +0200 Original-Received: from localhost ([::1]:41910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlZOs-0001X3-Pv for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jul 2019 09:46:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48489) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlZOg-0001Hm-CH for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 09:46:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlZOe-0003Ro-A6 for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 09:46:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56589) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlZOc-0003La-3T for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 09:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlZOb-00061S-Vi for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2019 13:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 34233-submit@debbugs.gnu.org id=B34233.156285273121241 (code B ref 34233); Thu, 11 Jul 2019 13:46:01 +0000 Original-Received: (at 34233) by debbugs.gnu.org; 11 Jul 2019 13:45:31 +0000 Original-Received: from localhost ([127.0.0.1]:37174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlZO6-0005WJ-Kk for submit@debbugs.gnu.org; Thu, 11 Jul 2019 09:45:30 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:55230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlZO4-0005U5-Lh for 34233@debbugs.gnu.org; Thu, 11 Jul 2019 09:45:29 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlZO0-00046H-BU; Thu, 11 Jul 2019 15:45:26 +0200 In-Reply-To: <87y3161548.fsf@gmail.com> (Noam Postavsky's message of "Wed, 10 Jul 2019 07:49:43 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162691 Archived-At: Noam Postavsky writes: >> + ;; Top-level. >> + (and (zerop (car syntax)) >> + ;; Not in a comment. >> + (null (nth 4 syntax)) >> + ;; Not in a string. >> + (null (nth 3 syntax))))) >> (push var vars)))) >> `(progn ,@(mapcar (lambda (v) `(defvar ,v)) vars) ,exp))))) [...] > There is already a function for this particular case: > syntax-ppss-toplevel-pos. Are you referring to just the (car syntax) bit or the nth 4/3 bit (which are the same as nth 8, apparently? (And which I've now committed.) Feel free to touch it up if you want to, but I couldn't convince myself that they were equivalent... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no