From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master ed29d9f: Add edebug specs for inline.el Date: Sun, 14 Jul 2019 13:55:50 +0200 Message-ID: References: <20190713160723.15224.93024@vcs0.savannah.gnu.org> <20190713160724.DE848207EF@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="152282"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 14 13:56:07 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmd6r-000dU4-KN for ged-emacs-devel@m.gmane.org; Sun, 14 Jul 2019 13:56:05 +0200 Original-Received: from localhost ([::1]:59850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmd6q-0001Du-MI for ged-emacs-devel@m.gmane.org; Sun, 14 Jul 2019 07:56:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40559) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmd6h-0001Dn-TO for emacs-devel@gnu.org; Sun, 14 Jul 2019 07:55:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmd6g-0007M9-R9 for emacs-devel@gnu.org; Sun, 14 Jul 2019 07:55:55 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:45056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hmd6g-0007LH-J2 for emacs-devel@gnu.org; Sun, 14 Jul 2019 07:55:54 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmd6c-0001t6-Qz; Sun, 14 Jul 2019 13:55:53 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXZjUjrsVvwzZc7AwBg DQCJHgCvTw797bBJhb/SAAACaUlEQVQ4jU2SsXLbMAyGIV/MrrLSU1YTQ/UAlPsCIj0nZ1Ez04To XC56/f6gZCc6WyL54QdAAHTanl5C9H5y3l/T0xRipB20Esd5cmFZRHKM0/gFMhTOje6S/RiW7wo/ TgBBsuRp9A9gslOFG/0NDvOXgj6dKpxDYOTwAD0AAuA3+rjkeboDompefangoUimnuF1ifIt3TZ9 qrXfZHB2V7TyUU9UFiM+ge4VuTk3h6g04nkENzK5xSTZM/gKbkQWyiHJXBXe3YOLCJ2MfxXVwD7u rlqRhBU184gyaS13V73kKzWq9NNFg0+O9hCfLikgo+F9iDPtoT/uIFR7V8tugkABV71Q9j6E/R7G B0E3iE4208dWyABXR/Qf2QZDyMzoHFRfqsVgIF2jU5A3e72H95tCjJgYb6PutQEAMWJkUBEhE2fd bveALC9G0pVkkTjfizhTjGFB3DYRGrdEHzZfDuCVekoshNjyOut5LSLMDKWODdJa5P24j4QHEJPo B/earzRNr/3z1ZWktmEmBJF06vjJT+oO4G1Yh3J+J4B8YrY3vWOmuAzruhabWtV0zHxGa6+R4o9V H0udDjDO1+EZDQz0Vs8Lnw9sB+aBsZnDbaG/Faw8WBiXQf2uv+JF6OUOCtvVbuCfX4SwKvovK0NT sILVMQtpgKHotljL6wZ+RqZNXAGfhm3Jz7/b78AesB6gZyRMcIMdwFBa9TRoGk8AL2rBqi9dTYQZ pQbokFAFq+UKbNudFWBnO8iHlYetBM3hTOgHl3I64AIA9aLcN4cDqYK5/YOXaio4tgygE3to0R/L BQXUwEtzZoD/Zk8PM5keDcgAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Sat, 13 Jul 2019 18:30:18 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238580 Archived-At: Stefan Monnier writes: > I don't understand. Those macros already have edebug specs (in their > `declare` form). > > (defmacro inline-quote (_exp) > "Similar to backquote, but quotes code and only accepts , and not ,@." > (declare (debug t)) Oh, is `debug' for edebug, too? I assumed it was... something else... > I can't imagine how adding def-edebug-spec before will make any difference. Then me neither, but without the specs the test case fails and with it, it doesn't fail. Hm... Any ideas? Here's the "emacs -Q" test case: To reproduce, enter the following code into *scratch*: ;;; -*- lexical-binding: t -*- (defvar my-count 0) (defun my-number () (setq my-count (1+ my-count)) (message "my-count is %s" my-count) my-count) (define-inline my-divisible-p (n) (inline-letevals (n) (inline-quote (or (eq 0 (% ,n 2)) (eq 0 (% ,n 3)))))) (defun my-func () (message "the result is %s" (my-divisible-p (my-number)))) (my-func) Then: M-x edebug-all-defs RET M-x eval-buffer RET g g Result: Args out of range: [20 48 59 70 71 72], 7 -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no