From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#6300: browse-url-encode need to encode more Date: Wed, 21 Sep 2011 22:23:54 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1316637417 17768 80.91.229.12 (21 Sep 2011 20:36:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 21 Sep 2011 20:36:57 +0000 (UTC) Cc: 6300@debbugs.gnu.org To: Lennart Borgman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 21 22:36:53 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TXI-0006Kc-Kc for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Sep 2011 22:36:52 +0200 Original-Received: from localhost ([::1]:46312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6TXI-0002Jj-53 for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Sep 2011 16:36:52 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:53471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6TXD-0002Ew-Ld for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 16:36:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6TXC-0003F6-BC for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 16:36:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6TXC-0003F1-8R for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 16:36:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R6TXS-0006ic-KT for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 16:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2011 20:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6300 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6300-submit@debbugs.gnu.org id=B6300.131663739225763 (code B ref 6300); Wed, 21 Sep 2011 20:37:02 +0000 Original-Received: (at 6300) by debbugs.gnu.org; 21 Sep 2011 20:36:32 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TWx-0006hM-Pe for submit@debbugs.gnu.org; Wed, 21 Sep 2011 16:36:32 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TWq-0006gi-5o for 6300@debbugs.gnu.org; Wed, 21 Sep 2011 16:36:27 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R6TWS-00069B-VQ; Wed, 21 Sep 2011 22:36:01 +0200 In-Reply-To: (Lennart Borgman's message of "Sat, 29 May 2010 13:29:21 +0200") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Colder's _Heat_: "Burnt Out" X-MailScanner-ID: 1R6TWS-00069B-VQ MailScanner-NULL-Check: 1317242161.1274@tVDny1msWWjYBPwAWJy5iw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 21 Sep 2011 16:37:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51596 Archived-At: Lennart Borgman writes: > The character ?" needs to be escaped at least on w32 because otherwise > ShellExecute will not work. Maybe this part of the patch should be > platform specific, I do not know. > > Both Google Chrome and Firefox still thinks that it is good manner to > also escape blanks as ?+. > > I suggest the following patch (this is agains a checkout from 2010-05-22): > > === modified file 'lisp/net/browse-url.el' > --- trunk/lisp/net/browse-url.el 2010-04-29 14:04:33 +0000 > +++ patched/lisp/net/browse-url.el 2010-05-29 10:52:33 +0000 > @@ -634,7 +634,8 @@ > ;; FIXME: Is there an actual example of a web browser getting > ;; confused? (This used to encode commas, but at least Firefox > ;; handles commas correctly and doesn't accept encoded commas.) > - (browse-url-url-encode-chars url "[)$]")) > + (replace-regexp-in-string " " "+" > + (browse-url-url-encode-chars url "[\"()$]"))) Is there any reason space shouldn't be quoted as %20 instead? I.e., just add it to the regexp there at the end? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/