From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: Updated eudcb-mab.el Date: Tue, 17 Feb 2015 09:52:28 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1424184787 24840 80.91.229.3 (17 Feb 2015 14:53:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Feb 2015 14:53:07 +0000 (UTC) Cc: John Wiegley , emacs-devel@gnu.org To: Danie Roux Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 17 15:52:55 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YNjW3-00038v-IN for ged-emacs-devel@m.gmane.org; Tue, 17 Feb 2015 15:52:47 +0100 Original-Received: from localhost ([::1]:45801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNjVw-0000oF-TG for ged-emacs-devel@m.gmane.org; Tue, 17 Feb 2015 09:52:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNjVs-0000ny-FS for emacs-devel@gnu.org; Tue, 17 Feb 2015 09:52:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNjVo-0004ha-4Z for emacs-devel@gnu.org; Tue, 17 Feb 2015 09:52:36 -0500 Original-Received: from mail-ie0-f169.google.com ([209.85.223.169]:38831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNjVo-0004hQ-08 for emacs-devel@gnu.org; Tue, 17 Feb 2015 09:52:32 -0500 Original-Received: by iecrd18 with SMTP id rd18so41341534iec.5 for ; Tue, 17 Feb 2015 06:52:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=GF8ehJUfRMRMqcculKg5i2/YbjAt8J5sKdptS1JH8UU=; b=gYg/WAhzE22GR1fbyKaG2XTqHMYdxgLimdS39lIBm7iek3kF55AfaZEG9QHpqnK3ed UBb08kjAZixUCO6+vzuGL4l+2M3+x9xvRtRHIy2Tb/xU2T62O4kogRNbn5O8m/rzRi/i 08FKFNj+G/TjBoyJ/WFsywqr35vwb37YH38JbIsTLMmQcgbH2zAYQeJB0APEIVvtW7Jf tawzQgp+KAz+R6gdXrB8yxBDybkHM2uWXZgUmRHfw4YqSoeKA83rJmMdtlp12pn933fW mjy7XCNIKyfY8EBUSSpYdo9DrBC/IHa6sMlj9L7rmrkXKZ0VUk/ZO43rwF/buGizJ0Z+ nkoQ== X-Gm-Message-State: ALoCoQluyGFNPVlz0Ek9iRhU0CX5VIrCATmgGYB9Jjjow0krtCCWEPLkQFP7dbH/N4oSNdg90L0a X-Received: by 10.42.88.9 with SMTP id a9mr35289778icm.34.1424184750594; Tue, 17 Feb 2015 06:52:30 -0800 (PST) Original-Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by mx.google.com with ESMTPSA id 5sm10182161igr.17.2015.02.17.06.52.29 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 17 Feb 2015 06:52:29 -0800 (PST) In-Reply-To: (Danie Roux's message of "Tue, 17 Feb 2015 15:50:41 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.223.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183193 Archived-At: Hi Danie, Danie Roux writes: > Dear Emacs-devel, > > I've updated eudcb-mab.el to directly query the contacts database, > instead of using an external application. It looks like you're still relying on an external application, sqlite3, instead of "contacts", right? > Is this useful, what do I need to do to get the official version > updated? It seems like an improvement to depend on a standard executable like sqlite3, yes. It probably makes sense to change eudcb-mab in the way you're suggesting rather than providing a new backend eudcb-mab-sqlite, right? Is this patch backward compatible with the "contacts" format? If not, do you have a sense for how common the "contacts" format is these days? Would it make sense to obsolete the contacts format and support only the sqlite3 format in Emacs 25? > Please find the changed version attached. There are formatting issues where some lines are too long. Please wrap those. Are you able to provide a test database file with example data and a test procedure for using it for completion? That would be a useful addition. I haven't been able to test the MAB backend myself because I don't have access to a Mac OS or GNUstep system. Do you have a copyright assignment on file? This patch may be small enough that one is not required; maybe someone else could comment on this? Thanks, Thomas