From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Danie Roux <lists@danieroux.com>
Cc: John Wiegley <johnw@newartisans.com>, emacs-devel@gnu.org
Subject: Re: Updated eudcb-mab.el
Date: Tue, 17 Feb 2015 09:52:28 -0500 [thread overview]
Message-ID: <m3k2zgpp3n.fsf@fitzsim.org> (raw)
In-Reply-To: <m28ufwir4e.fsf@danieroux.com> (Danie Roux's message of "Tue, 17 Feb 2015 15:50:41 +0200")
Hi Danie,
Danie Roux <lists@danieroux.com> writes:
> Dear Emacs-devel,
>
> I've updated eudcb-mab.el to directly query the contacts database,
> instead of using an external application.
It looks like you're still relying on an external application, sqlite3,
instead of "contacts", right?
> Is this useful, what do I need to do to get the official version
> updated?
It seems like an improvement to depend on a standard executable like
sqlite3, yes. It probably makes sense to change eudcb-mab in the way
you're suggesting rather than providing a new backend eudcb-mab-sqlite,
right? Is this patch backward compatible with the "contacts" format?
If not, do you have a sense for how common the "contacts" format is
these days? Would it make sense to obsolete the contacts format and
support only the sqlite3 format in Emacs 25?
> Please find the changed version attached.
There are formatting issues where some lines are too long. Please wrap
those.
Are you able to provide a test database file with example data and a
test procedure for using it for completion? That would be a useful
addition. I haven't been able to test the MAB backend myself because I
don't have access to a Mac OS or GNUstep system.
Do you have a copyright assignment on file? This patch may be small
enough that one is not required; maybe someone else could comment on
this?
Thanks,
Thomas
next prev parent reply other threads:[~2015-02-17 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 13:50 Updated eudcb-mab.el Danie Roux
2015-02-17 14:52 ` Thomas Fitzsimmons [this message]
2015-02-18 19:56 ` Danie Roux
2015-02-20 2:52 ` Thomas Fitzsimmons
2015-02-21 15:57 ` Danie Roux
2015-02-22 0:40 ` Thomas Fitzsimmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k2zgpp3n.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=emacs-devel@gnu.org \
--cc=johnw@newartisans.com \
--cc=lists@danieroux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.