bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers

bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers

[Lars Ingebrigtsen]

This started after commit ea512a7c2cd30206dd509b193c9faaba25640180 with
the changes in mm-convert-shr-links, but I haven't examined what's going
on.


In GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.5)
 of 2016-07-12 built on stories
Repository revision: df7774be39af76d3072a0278ef815a47bf50dfe9
Windowing system distributor 'The X.Org Foundation', version 11.0.11604000
System Description:	Debian GNU/Linux 8.5 (jessie)

Recent messages:
/home/larsi/src/emacs/trunk/lisp/gnus/mm-decode.el seems up-to-date.  Revert anyway? (y or n) y
Finding changes in /home/larsi/src/emacs/trunk/lisp/gnus/mm-decode.el...
No changes between working revision and workfile
Reverting /home/larsi/src/emacs/trunk/lisp/gnus/mm-decode.el...done
(No changes need to be saved)
Finding changes in /home/larsi/src/emacs/trunk/lisp/gnus/mm-decode.el...
No changes between working revision and workfile
o is undefined
Mark set
Making completion list...

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Git-Log-View

Minor modes in effect:
  diff-auto-refine-mode: t
  global-whitespace-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t

Load-path shadows:
/home/larsi/src/cddb.el/expect hides /home/larsi/lisp/expect
/home/larsi/src/cddb.el/captitle hides /home/larsi/lisp/captitle
/home/larsi/src/clock.el/clock hides /home/larsi/lisp/clock
~/pgnus/contrib/vcard hides /home/larsi/lisp/vcard
/home/larsi/src/pvr.el/pvr hides /home/larsi/lisp/pvr
~/lisp/zenirc-2.112/src/zenirc-example hides /home/larsi/lisp/zenirc-example
~/pgnus/contrib/compface hides /home/larsi/src/emacs/trunk/lisp/image/compface

Features:
(shadow emacsbug log-view pcvs-util vc vc-dispatcher vc-git diff-mode
map eieio-opt speedbar sb-image ezimage dframe find-func thingatpt etags
flow-fill xref project ring pp sh-script smie executable misearch
multi-isearch eww mailalias smtpmail sendmail ecomplete gnus-html
url-queue help-fns radix-tree url-cache shr-color color mm-archive sort
smiley ansi-color gnus-cite gnus-async gnus-dup qp gnus-ml gmane
spam-gmane dns mm-url disp-table copyright vc-cvs gnus-fun gnus-mdrtn
gnus-topic pop3 nndoc nnmbox utf-7 nnml nnfolder network-stream starttls
nnir spam-report spam spam-stat gnus-uu yenc gnus-delay gnus-draft
gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache
gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum
nndraft nnmh gnus-group gnus-undo gnus-start gnus-cloud nnimap utf7
netrc nnoo parse-time gnus-spec gnus-win nnmail gnus-int gnus-range
mail-source message format-spec rfc822 mml mml-sec epa epg mailabbrev
gmm-utils mailheader gnus nnheader gnus-util rmail rmail-loaddefs
mail-utils whitespace movie mkv shr svg imdb dom pvr debug debbugs-gnu
easy-mmode derived debbugs soap-client mm-decode mm-bodies mm-encode
url-http tls gnutls url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr url-gw nsm puny url url-proxy url-privacy
url-expand url-methods url-history url-cookie url-domsuf url-util
mailcap warnings rng-xsd rng-dt rng-util xsd-regexp xml ido flyspell
ispell benchmark w3m browse-url doc-view subr-x dired dired-loaddefs
image-mode timezone w3m-hist w3m-fb w3m-ems wid-edit w3m-ccl ccl
w3m-favicon w3m-image w3m-proc w3m-util add-log mail-extr jka-compr cl
finder-inf package epg-config url-handlers url-parse auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-cache url-vars seq
byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv
cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote dbusbind inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 1233450 110298)
 (symbols 48 172606 205)
 (miscs 40 293 1193)
 (strings 32 264070 10714)
 (string-bytes 1 24323386)
 (vectors 16 43931)
 (vector-slots 8 1801005 216852)
 (floats 8 7154 1257)
 (intervals 56 105894 986)
 (buffers 976 84)
 (heap 1024 189423 116274))

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers

[Katsumi Yamaoka]

On Wed, 13 Jul 2016 08:52:25 +0200, Lars Ingebrigtsen wrote:
> This started after commit ea512a7c2cd30206dd509b193c9faaba25640180 with
> the changes in mm-convert-shr-links, but I haven't examined what's going
> on.

Because the change was done first in emacs-25[1], in which shr-map
(not shr-image-map) was used, and then merged into master[2].

[1] <http://lists.gnu.org/archive/html/emacs-diffs/2016-06/msg00173.html>
[2] <http://lists.gnu.org/archive/html/emacs-diffs/2016-06/msg00203.html>

I'll fix it in master.

Thanks.

bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers

[Lars Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> On Wed, 13 Jul 2016 08:52:25 +0200, Lars Ingebrigtsen wrote:
>> This started after commit ea512a7c2cd30206dd509b193c9faaba25640180 with
>> the changes in mm-convert-shr-links, but I haven't examined what's going
>> on.
>
> Because the change was done first in emacs-25[1], in which shr-map
> (not shr-image-map) was used, and then merged into master[2].
>
> [1] <http://lists.gnu.org/archive/html/emacs-diffs/2016-06/msg00173.html>
> [2] <http://lists.gnu.org/archive/html/emacs-diffs/2016-06/msg00203.html>
>
> I'll fix it in master.

Hm...  it still doesn't quite seem to work.  It works for plain <img>
things, but if it's <a href=...><img></a> then `+' from image-map
doesn't work, and `a' from `shr-map' doesn't work, either (in a Gnus
article buffer).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

On Wed, 20 Jul 2016 14:47:38 +0200, Lars Ingebrigtsen wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>> I'll fix it in master.

> Hm...  it still doesn't quite seem to work.  It works for plain <img>
> things, but if it's <a href=...><img></a> then `+' from image-map
> doesn't work, and `a' from `shr-map' doesn't work, either (in a Gnus
> article buffer).

I realized `+' works for some html mails but doesn't for others.
In a mail in which `+' works, the keymap is put on an image.
However, the keymap is put on the right hand neighbour character
(usually a LF character) of the image in a mail where `+' doesn't
work.  I'll work it for more...

Here are two examples:

[-- Attachment #2: `+' doesn't work --]
[-- Type: application/octet-stream, Size: 405 bytes --]

From: yamaoka@jpl.org
To: foo@example.com.invalid
Subject: test1
Date: Thu, 21 Jul 2016 12:34:56 +0900
Message-ID: <b4m37n3mpk3.fsf@jpl.org>
Xref: yamaoka-PC.twa.co.jp tmp:672
MIME-Version: 1.0
Content-Type: text/html
Content-Disposition: inline
Lines: 4

<a href="http://www.gnus.org">
  <img src="http://www.gnus.org/pictures/gnus.gif"
       alt="http://www.gnus.org/pictures/gnus.gif">
  gnus.gif</a>

[-- Attachment #3: `+' works --]
[-- Type: application/octet-stream, Size: 8836 bytes --]

From: yamaoka@jpl.org
To: foo@example.com.invalid
Subject: test2
Date: Thu, 21 Jul 2016 12:34:56 +0900
Message-ID: <b4m37n3mpk3.fsf@jpl.org>
Xref: yamaoka-PC.twa.co.jp tmp:676
MIME-Version: 1.0
Content-Type: multipart/related; boundary="=-=-="
Lines: 124

--=-=-=
Content-Type: text/html
Content-Disposition: inline

<a href="http://www.gnus.org">
  <img src="cid:fsf.1"
       alt="~/tmp/gnus.gif">
  gnus.gif</a>

--=-=-=
Content-Type: image/png
Content-ID: <fsf.1>
Content-Disposition: attachment; filename=gnus.gif
Content-Transfer-Encoding: base64

R0lGODdhvgDDAOcAAMn2sfL/6vH/6e//56zXm/f/8vb/8fT/78Dsq/3/+/z/+vv/+fr/+Pn/97zo
p6TNlvT58qLNlLbXq97t2bXXqt3t2LTXqfD37tvr1rLVp+z16tb/vdX/vNT/u9P/utL/uc35tMv3
stv/xdn/w9f/wbHcn7DcnuD/zd//zN3/ysjmvNbszb/rqeX/1eT/1KbSl7naraTQld/w2aPOlMft
tLTWqLDUpNjq0uv06On/3Or05/7+/sHeuOj/29Xoz6zSoKvSn9H+t6jQnLXhou3/4+z/4vL/69z+
yMf0sMTwrdfvzavXm/n/9fj/9Pf/86bRlv///v7//f3//Onz5fz/+/v/+vz9++fx46rRndLny/r9
+anRnL3bs7zbstDlybrmprvbsfj798/lyPf79qbPmbrZsOLv3uHv3fT588vjxNf/v9b/vtX/vdT/
vOT42cz5tMn1scj1sNz/x9v/xsfzr9r/xdn/xK7ana3YnKzYm+D/zsv1tt//zef/2Ob/173pqOT/
1dHmybzaseL907rlpePw3vf69abOmKXOl/X687jYraPOlfP48aLMlMriwqHMk7PWqMfgv8bgvu72
7MXgvdnq1Oz/4Ov/36/UpOr/3uv06en/3ej/3M/8ts36tMz4s/D/57Pfoe7/5a/bndT8vvb/8PX/
7/T/7vP/7cTwrsPwrcLurL7qqPv/+Pr/9/n/9qfTmKbRl6TPlfP58Mjhv7LVptrr1O716+z16djp
0sPfuq/To/////7//sLdua3TodP/udL/uPv9+6rRntD9tr3btLzbs+Tx4abPmrnkptj/wdf/wNb/
v9z/yNv/x8fzsMbzr9L3vqrWmqnUmeL/0afSl93u1sLeuK3SoP3+/KzSn/z+++f047/ctb7ctPr8
+dHmyvn8+KjQm9DmybvasePw3/b69aXOmM3kxvX69Lfjo6HMlPH48Mjiwe3/4uz/4c36tQAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACwAAAAAvgDDAAAI/gB5CRxI
sKDBgwgTKlzIsKHDhxAjSpxIsaLFixgzatzIsaPHjyBDihxJsqTIXl68CDPJsqXLjN8m1ajx6FGG
GjDszNnpRMrLn0CDjjFWs2hRPCyCKdWjIKjTpyO5GJ1a84vSYHqgat2K0Rw5qmDVBbnKiavZswx7
fQULltDVYO+2QsCF6xbauwQvsGUbQR0xpSmaPvVC8xGZlBPwnsW1a+9eOFf5+AR6pvBUZDUumMvm
UJi5z6A3K8Z44YfjvXjeUgMqTNfpR1kannFNtd2x0RYhvWZb7a0coJF2P7ihkB0XMnuxcHGEW2IF
5Lup9r7KYYDLcNeiP+oy5mChtdF9/thtzjAcD+1gh6im0pIS+kfkDOZ6X9PGJPILcdCfOg3A2wIm
hUNJI/R10x0v2YDzwH6PiMMOfgnZYJQ0FEozg3ZJ/GdSIQw+UowWvKTTYU2YaAChQWacU5MF47yF
wDiNvZbhVQCSFMYvI3ajxXkjPoLNgycKZIUvNWGBRgtKAdOHE7ywo8GAjs2oVI0iXVBLjx6ahiU2
JgZ5RlFAOFGHUr8VRBtbUgZDZUiVYOmmUZgAiV8vltlSxFVlEqTfXmmuWRAOOGD05ZuENjgeeToY
hQsgVy1wkBh8aogQFz9IEk5FZghRaKH24deFUdy85ahBuGiDpqQFZZPFgo9gkcZK/hGdoSJV0xDi
iSfqTLMpeg42N4YiRaFzhKgI8ThVKGPReJA5VElSzkMXeHEIVbF84clbnnwRy67RlYjbDUaBI8JV
ekxmEBrpvaXmQdlAOpUunDF0I1UzxIKEuldBE0sE2skSy78AL8Lgj6NVwGotbnBwFREJmQOdUeqh
WlCbtTFkJVh/4IvvH9ENQQe+CAwhzX5cjvbpI2LwMm4wypiiELhTRayUM64gRDFVCzlyJVgaa0zI
aaOo0rNSIaiiyhLvgXNWLmkMlGg7nAkQzAcGLAQzxG/lkNAxmlJFAQQHHZMdWNXEoe4yJ/T8B79g
lTC0xkijV0lGNyh9kVcUDNRL/jG38eJKMAEwdHVRMgejdUJSgWVLQbdIgghbsnz8Vg+n8EIEEQqr
+wVbZr+t7ht4oHdOBRdhgIjdFan1SN4HSUFEzQqFA6xRkWetUOJUITNMGnR5g4xjqSm1DDWt9EKQ
KcyoG4QDFxolluf4dkIAeojMTdENiEACa0W0+WIRulNNd9Xhk2J5x7XBjFD1Qaf0ge/IRcUCDfQa
exK6do1QVEFNrFfEWE2G+J501EW+g7BjRLJIBTyUsgEmKKQXm/DAW6BhlDsopQNq0IMBNshBA7hA
DR3Alyemp50aYMB4DxFGGfhnkR1koSZiiBdFwGcU8QWjDq1YSIeqMb+rBI4h/u94Syfuh4dOBKMD
1lFIAACRAnUN8T0YSCGRYCjAmtjCCFWsoW8WkoMOdU4pKBgVQwKAAqsEgxWPWMIblOIOh7jCGZ+L
W3SQwQU5KUQSRjFHFSWAhhHw4RUzHCCeFNIAZ8hRO2V7ixogYoivWCUVJrjKCBz4EDng65C7EUch
DnSQcBQCRzXJAgoqcgFQgsMF6QPkRGhYFMgMMiFECIYq3lO7t2wCIhx6hBmvooz1PcQVTXwL6OhD
DklI4hsEaVw3psICZ1CEEbp5RAQKMALDVYSVNXElmRLSix7IEj2xkNwFL4HChrDjd93YRAivshqJ
JAAFybuK9BiEhWHYcxi//pvKHYjRhIHoYhhZkGFCIADKR1SADUopYESw+QhtBqOfCGGAUmYZHfm9
RQ8Me8j/HqHHObwlhxQ5RTyVYj9uRRKkG9WjQi4QzUdYwA3Cq1wgp+JQMRqEGkrpRAleM4MvhOCi
NrWYltLgAl6c4oKbKOdETpE5kpKwUJ/ogfFcWJRrIGQH6ZBEQSOADj6AMYutJBZCPKoUBDRvL6xQ
1ygjEk1s7IEEBqBCE7OCkVOQQIj3e9MogpFRVmKjEmEgCAYq8cKphGlMwQjqQqeyBBCI9SBSuwoa
9+KWt4QxIhOAjhuWYU13BKMUGilFHAmVBDnADo9TUQQXVssFVlEFCJ4N/oYfomAR1BZll7KlLUIU
gNiymgB+NZlGKPBFV4hcTQlKmYNAjADajZRCGerCJIPKVtyWvsdtwWAGKi5iXV2+RRQLaUJvicaC
8rLAoUtRLEOwUBM8rDEY4AUJU4WZ1w6pZ7u8MIM4GOTK4lbEurBwaHwV4gf6kctcDgmHLggECSMG
4xJQEIlIhfhU+sTiDp0YgUCEYVv0LMIBY/mAYHJjlCVYFsEJwSn9yiWRXMJgEEpRH0kmfJWSWriH
P9wTfTKmlA9kxLomJpdDULHOoW3AAOpdyLwkMIh1tnPGTQ3GCGl5ryPiVwL7kcUClRKXi3xjZzWp
slKK6pABFBlfdvCT/kMu9ghRRGYjx6jEBRRiV7wiUpyAEMgVHqYdWIjTDky6iLuKsuVgACMiqFCx
uiyhZodQrB3BvGxGuPaIWjAnIaIVpnTb8sVg5JkXHdZOpz8taKM4osiHrogemGKRQcEABUpZpEas
QAuj+KJvB3muukxgArZRBQ9pfcsyBhLq08wg2FcZdkYG/YikXAWLTikMcpVyS42ggyqjS8h81YUA
FjigJtIwb6GvkomBTIHPp8GtUsqNEWgWBRLReAu0fyKMNAhsBQjtADk1kg4JUaV62h7pW4JwKwcT
t3gEmd1pSuCJZF1FDRC9iI4f0Q1UKoUauv0JLmpSg3gHQ7kUuYJK/gWSDoVTJX8BN/CBDXKB+tLq
C385m0wxMnEYkDUYLQhKOLAsjoQFgwMum8gUsICJ2AjkGKeJxPYMsu0VV+EgRrCfLKYSgX99QmNA
h3NRIgDTJPUhKKjlwcJCjpxzJIYXe37N4rR9V8/ZgdQGiSc0hjCKR4RiCOoYmjIOwJGuSTOywVD2
T3BgGl94NRimnQjha2I9UO9m7Zj25tDYEGiECBweqnB4z3ypEb+P4+aCf0lNkEEDpTRjIhCwjA2A
dO3ojFwhTFi17FcNCoboQeUs43zni1IOibVkPo9YAVl/CBHZFaVkvIACel7vkUzTj3IeMR3vfW8S
gz3iB6QwdA8y/u6QdGC5KN3wAzP6cKbdxCckvbjEmTWmb6VuxD010cXtYx1xlnxDKpiQQQhlDZGS
G6UYMOZpEzBFu2EBJHEJb4NRIQF/j0ALsJZQP8EjuoBTHCAAEGEF3mcUM0ADwJA+NfMNSqArr2GA
IxEFm6AGbwEMaqAGBvB0IDEkRTILwQQMl/ASuKAlSGJNEFFrU4Fs6wNMbzAEMXAaJFgSgHCEgNAD
JTEoj6ANd7JNL+EFMKQUykBJDjEOPHNx7MELcDRRp4EMZxckslEUTvhKv1cTiVQHI8YQtCYdneNM
AmEKbwEPwMUWqCOGCrEDisIoSpFkIjEMNRExGeUQrUc74hRf/qfAWW8RAnVIFXeIh1cFKo9VEgpG
IE9gRCiAYglxBlggMEYRC89wFSQgGFLQCtA1h47xiJBoEASIDk3AS2tIErn0CHkXDLXXEIUwLVNh
UTGme02QA2cWCnuhiqtIECfzCOCQCWPXEgVlNjW4EMKQDpCwXxroAD/FTggBCkWWCp7oiMWIEGcA
HbVgDogVGC2BdLcFaNBIgD2oLnygRGtwFUNgh994EFczDqWgiP5VErjzCLEAdwYBBROwQm2hVn4o
EIA3j2BBjMUYBjuzDmMgeVTTEqlnFDEQDcw3ELeQT/SCbEvRELylFGuzkPVYEDSEAQqgYqnGEjdj
FMVkKQIx/gXG5G9ggVvKQAQuyBDipRRPQJIlORCFiAFyqBR+0BIO4xhbgAVYgG5T8WEORwJW6BAF
Fgw9ORUZsHQlGU1dYAVDuQZBZxI+gCUm4Gy9OBFKoQ5UUYQ/yQu60QiJMZU5Z39gxiAmMG4NRBEI
GAdpuZYCgT3SJBDxiHMtIYUdMg2F0wGAUHkSITV6ORVqWZLuEgGAeURJZBLM9h4x4B9v0UYWsQAo
0JhG8Zj16C7jwAuXIEGhRxIbl2UmcHXUcYsX8Q5wsJcvIQUCAIccoWO3YXGpORKrSR8IgC8DhhF7
QBU08BPuU5QdoZu8YHHsZhK/2S/B+RbOIAoRphHFORUa/uYSrlBNxLcRExB/2WAE69RoIRGduxEK
q6AuT7YR2VkUJlAHLyF5P5QFV6AR7NWAvKBo5gkSwtAOvrYXsiANcWBwhuYCW8gR71kTLLBWLOEE
8RQ44LAIDBkRE1oTtNALVwEImjgSPfAzjhEKaXIVZOYRC1oNdABSLJEDPjQLwFKhEIFaZhcA4zOf
QYCWYJEESaB5MRYACdoRC2o2KmoSgQk4gwKjDqEDpvIIQMALD6iDLSF5X4A0d8BrHqkuaigS70kA
NxSLI2FxntYLoxeGFcGEQPAKZMUGsMkSkhcMb8ACMTc0RFB/H/GeGTKIJUFNGwp8/ZM64JEFT4h4
P0EE/uvXMx7gDN8ZEtkZAx+Dpwd4FcyQCLPTpxShh0UxBW1ghi6BgJ6TAs9YEtmpHjJmElDwFoNw
jJQ6ERggiVdhCUABQRKEL8uQCQYwpCSxB4sQA461jyIhBWAKCNEpCBhxjLQQTH3oFEXwgM6AhEDB
DKpQi0XAErEVDGsQANaVkRJxjODQWymQAE+xAAEQAFH5EyOlUCIRkkoRAM9RFI4gUBNBaaHUW47K
lxIRT73EEqBwFSJgDsbiDXRTFBTQpnxFrxYRTwA5EmRVB02gY42AaxZxNQF7FQpLsBVhsCyRCR0o
W7xAk2RaEUdZExfQprxKsQ+RPG2QqCEBTD2WX7NC/gF2dE1GIYNXsaYkCxGgsAwWaBJGcBXvAIPS
hA4acQtFgQwDcBUrWbO4EU+AZgZFIQkb0VK2MJTB8I5IixvvEKuAQCc10QiHghFQe3jBMG9VexeA
lxWJUhNIChGlVBS2UKRiO7Zn8aRVczK/0CXLZhRt+2xwexevqBR9sA0KUhPesxGDRg6D8AFK4ZV7
ixEdixGHtwynwErYWhGDVnFXEZeLWxHfMLgaAQqZM0rLBEPuahGTkJ/boWiYm7kSMQZcYLcYIQWK
1gqlUhO/MAW5aRQq8Bapq7oQUQyP4LoXAaYtEAWVu5xbB3hroJi86xAb+bsa0QSnqF0M6xGmGwFt
/tqby7sQtyAh3hBYGIGmQnYml8YR1Sts2QsRYfkIafB1DbEAejCuA1FNPaYAjECNQmC7HWG6FfAW
KXC+DrE/VaF7CJEAXjWqBCEARfYBLFUUkfARptt7yuK/0EiQuiTAB1EA5HadAgEKG/AWl1BQQoAG
HnGhNSED1CfBBCEMBBgDSWDBBZGPbzELgOUE06oUdmANRuG0HmFbteBxU4LCCdFhSzCRCgG96gID
jwAG4xUMbGANfse1H2FbtAC21OCtQMxyBZVG5hp36qKQj1A4wUAKU5G2FCHFYLvFQDwL3YUAaDwQ
onBmcCCCX/wWquANRlG3IGHGNXrFBRGeRgEL/vDQxrygAPNHNFNXFMcWB3FgVlMxZx9xDI/zCMOQ
CbEKpXzMskYxDXCgBjMHWepSd9HhDVi5EWYaqJB7yXpGjUUxXLh5EAtwikqxCof8GorgvR9RyprK
xzxYFHsVDK1sEGAbDMQgjNFBHCGxy0AQqHnCx1g4FTOCsgMRAEUqZdoRCCJhqTXxA0EEhXxckYgc
bFl6EH+ziLAQHQ18zazKzUBsfEbhAEoxsQjhPm8Boq+BDPgbEulbE6GSyxJ8BVPxAteonOIsv7F8
VqdRBiRxjI+wz+rcz6brjz3UngYhsFSpHcD7EQrN0IIKxBfw0I/Qyx2AXwcBoVdBDOoQoI5B/gtW
kNBFQQY68BZfKcHgMBVFRJkKwaJXQVG7IQTPwtJoG0uNAsQ+4FoMqhTzShBQMFIfgEleQCBgkaog
cTJxsjK5hcJeMRVmNEkKAabBgMNFgQjEsXhTAQmXUhIn0w4qoxTaBcTgURRU6MICoaeAgcRFYXS8
cG5FsQ624MhmDUBpjRUcPRUsfHELwanZZQuuBQR8zQtdQAEU4AWTGxKf4gPG4wRT86PZu1E1IQsz
wmIK8RYfoNBkbBJdYANd8jcSvbxjsKRFIQ0XVJkIMZVKIQNGoQiR/RLsQAkD4QohjcKrWmLvFa0L
AbbOkMW3/RSusLvLu65GYUY+thBGUKQ9/tBS7aoYUaC8vGseMfPWCxEFfMjECIC3qIwW5VcT18IG
nYwQ45xTLZUBiz3eUJEGTr3Z09m/DGGsJICONeGv8L0VC2wUkRQMKWCrY7UwjmAUjdvfQJHFjxAD
V+cBn6oQ7rBOKZAIfrcFCq4V5cAfmqmEDdGmRdBhPZ3hQQGvhNNjBI4QkpcDSloU3EHiQdGGRoFd
a90QmdZLTFsTYA3jQVGIRdE5I4sQmZZn4NGkPP4TPtCNj7AIfzAWI4DZClG0zJAAYloTQBAoR+4S
/ldiMwO/CpE8w1blw3DPWc4SJtfgZgMMHl6ytsgL7VATXVDmLpF2RuFsJeoQ81U1iXPc/nLOES1u
FHmwRkT8EKhEDezxKRHA532uEVTBpUxMsw3hAmrKCxQDeYsuEsBnFDPyyw7hAvFV6Zc+EhhA1BGQ
DGMBlRORANfZJuSw0qEOEt9AFJ+4jBbRJvz96h8RukUhC0KDFTlZEZUgBIyA6x+hCVpyW0pBtRgx
BfdB7B2xtpnsmtDs7Fvh0Y9wLR7AmdSOFhUQyav8F/y37WYByVPhF4EX0+K+Fcbi1hCY7mbx5kax
CM6WAgfp7i7BZieuFClu7z8xBnPZ4Jo5W/yuFd31CJ1TbQP/FPo1FXWpFAkPFbcwK639F9X68E9x
4FPBYwdr8S0RDn73CDMAYsFgB7DD4vE/EWoBHgxwbfIk0WER0DmGzvI/MYs10esgJ/MvQcGP4F5K
MZw4zxKf+BdsYJ0/7xIAXBO1GORFLxK4MwQUr0pLbxJsNtiAE/UtQTERMCMnUO9WvxEiUtTBEO5d
PxJfLw3XiPBjPxIE6WB94H5pDxI0MVxhn95v/xGVgAglYERs0Fx1HxJj0AWLMJ1H3fccsXErYHol
T/gfkQs2sGWKPxISIAMIJdCP7xGMEJHBgHGVDxLl4AQpcLKbHxIGEAw5G/ofkQOJZ/ofkQJervoY
UQDc5/obYQodKvu2f/u4n/sKHhAAOw==
--=-=-=--

bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

On Thu, 21 Jul 2016 17:46:18 +0900, Katsumi Yamaoka wrote:
> I realized `+' works for some html mails but doesn't for others.

I'm not quite sure this is the right approach, but I seem to have
found the cause and the solution.  `shr-image-fetched', that
`shr-tag-img' calls, overrides the keymap text property on an
image with the value that was there before inserting the image,
that is, nil.  Could you please test this patch?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 405 bytes --]

--- shr.el~	2016-07-21 08:35:17.668496000 +0000
+++ shr.el	2016-07-22 11:05:56.349491100 +0000
@@ -937,7 +937,7 @@
 		(while properties
 		  (let ((type (pop properties))
 			(value (pop properties)))
-		    (unless (memq type '(display image-size))
+		    (unless (memq type '(display image-size keymap))
 		      (put-text-property start (point) type value))))))))))
     (kill-buffer image-buffer)))
 

bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers

[Lars Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> I'm not quite sure this is the right approach, but I seem to have
> found the cause and the solution.  `shr-image-fetched', that
> `shr-tag-img' calls, overrides the keymap text property on an
> image with the value that was there before inserting the image,
> that is, nil.  Could you please test this patch?
>
> --- shr.el~	2016-07-21 08:35:17.668496000 +0000
> +++ shr.el	2016-07-22 11:05:56.349491100 +0000
> @@ -937,7 +937,7 @@
>  		(while properties
>  		  (let ((type (pop properties))
>  			(value (pop properties)))
> -		    (unless (memq type '(display image-size))
> +		    (unless (memq type '(display image-size keymap))

Yes, this seems to fix the problem.  Thanks!

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers

[Lars Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> I'm not quite sure this is the right approach, but I seem to have
> found the cause and the solution.  `shr-image-fetched', that
> `shr-tag-img' calls, overrides the keymap text property on an
> image with the value that was there before inserting the image,
> that is, nil.  Could you please test this patch?

It works for `+', but commands like `a' and `RET' no still doesn't work
on <a><img></a> links.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers

[Katsumi Yamaoka]

On Sun, 24 Jul 2016 10:27:51 +0200, Lars Ingebrigtsen wrote:
> It works for `+', but commands like `a' and `RET' no still doesn't work
> on <a><img></a> links.  :-)

I was confused about what key bindings should be there. :-)  But
this would probably be the right way:

--8<---------------cut here---------------start------------->8---
--- mm-decode.el~	2016-07-14 02:18:17.358607500 +0000
+++ mm-decode.el	2016-07-24 22:48:23.134292500 +0000
@@ -1853,8 +1853,6 @@
 	 :help-echo (get-text-property start 'help-echo)
 	 :keymap (setq keymap (copy-keymap shr-image-map))
 	 (get-text-property start 'shr-url))
-	;; Remove keymap that `shr-urlify' adds.
-	(put-text-property start end 'keymap nil)
 	;; Mask keys that launch `widget-button-click'.
 	;; Those bindings are provided by `widget-keymap'
 	;; that is a parent of `gnus-article-mode-map'.
--8<---------------cut here---------------end--------------->8---

(Don't apply my last patch to shr.el.)

How about it?

This used to be making `local-map', not `keymap', void:
<http://article.gmane.org/gmane.emacs.diffs/136052>
The reason I did it was there's no code using `local-map', and
so it was never effective.  So, the patch above only restores
the old behavior. :-)

bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers

[Lars Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> -	;; Remove keymap that `shr-urlify' adds.
> -	(put-text-property start end 'keymap nil)

Yes, with this patch all they keys seem to be there...

> This used to be making `local-map', not `keymap', void:
> <http://article.gmane.org/gmane.emacs.diffs/136052>
> The reason I did it was there's no code using `local-map', and
> so it was never effective.  So, the patch above only restores
> the old behavior. :-)

Ah, I see.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers

[Katsumi Yamaoka]

On Mon, 25 Jul 2016 20:44:27 +0200, Lars Ingebrigtsen wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:

>> -	;; Remove keymap that `shr-urlify' adds.
>> -	(put-text-property start end 'keymap nil)

> Yes, with this patch all they keys seem to be there...

Thank you for the verification.  I'v committed it in master.
And I asked emacs-devel if I can backport it to emacs-25.

Regards,