From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#27610: iimage mode patch Date: Mon, 24 Jun 2019 18:25:17 +0200 Message-ID: References: <1499450328447.12324@rwth-aachen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="71193"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 27610@debbugs.gnu.org To: =?UTF-8?Q?D=C3=B6ring@debbugs.gnu.org, ?= Arne Frederic Maria Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 24 18:26:31 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfRnZ-000IJJ-J3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 18:26:29 +0200 Original-Received: from localhost ([::1]:53006 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfRnY-0005pi-Iz for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 12:26:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59784) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfRnE-0005m0-AZ for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 12:26:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfRnA-0005VJ-Vf for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 12:26:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44233) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfRn8-0005ST-2a for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 12:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfRn7-0006eF-TM for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 12:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2019 16:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27610 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27610-submit@debbugs.gnu.org id=B27610.156139352425483 (code B ref 27610); Mon, 24 Jun 2019 16:26:01 +0000 Original-Received: (at 27610) by debbugs.gnu.org; 24 Jun 2019 16:25:24 +0000 Original-Received: from localhost ([127.0.0.1]:57774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfRmW-0006cx-39 for submit@debbugs.gnu.org; Mon, 24 Jun 2019 12:25:24 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:33042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfRmT-0006ck-CB for 27610@debbugs.gnu.org; Mon, 24 Jun 2019 12:25:23 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfRmP-0005H2-Nx; Mon, 24 Jun 2019 18:25:20 +0200 In-Reply-To: <1499450328447.12324@rwth-aachen.de> ("=?UTF-8?Q?D=C3=B6ring, ?="'s message of "Fri, 7 Jul 2017 17:58:48 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161242 Archived-At: "D=C3=B6ring," Arne Frederic Maria writes: > `iimage-mode' binds C-l to `iimage-recenter' and this forwards to `recent= er'. > But the default function on C-l is `recenter-top-bottom', not `recenter'.= I > made iimage mode call `recenter-top-bottom' instead. Makes sense to call that function instead, yes. But: > (defvar iimage-mode-map > (let ((map (make-sparse-keymap))) > - (define-key map "\C-l" 'iimage-recenter) > + (define-key map "\C-l" 'iimage-recenter-top-bottom) > map) > "Keymap used in `iimage-mode'.") [...] > +(defun iimage-recenter-top-bottom (&optional arg) > + "Re-draw images and call `recenter-top-bottom' with ARG." > + (interactive "P") > + (iimage-mode-buffer nil) > + (iimage-mode-buffer t) > + (recenter-top-bottom arg)) I don't think this is necessary -- instead iimage-recenter should just call recenter-top-bottom. I've now made this change on the Emacs trunk. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no