all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: =?UTF-8?Q?D=C3=B6ring@debbugs.gnu.org,
	"?= Arne Frederic Maria" <arne.doering@rwth-aachen.de>
Cc: 27610@debbugs.gnu.org
Subject: bug#27610: iimage mode patch
Date: Mon, 24 Jun 2019 18:25:17 +0200	[thread overview]
Message-ID: <m3k1dbrlw2.fsf@gnus.org> (raw)
In-Reply-To: <1499450328447.12324@rwth-aachen.de> ("Döring, "'s message of "Fri, 7 Jul 2017 17:58:48 +0000")

"Döring," Arne Frederic Maria <arne.doering@rwth-aachen.de> writes:

> `iimage-mode' binds C-l to `iimage-recenter' and this forwards to `recenter'.
> But the default function on C-l is `recenter-top-bottom', not `recenter'. I
> made iimage mode call `recenter-top-bottom' instead.

Makes sense to call that function instead, yes.  But:

>  (defvar iimage-mode-map
>    (let ((map (make-sparse-keymap)))
> -    (define-key map "\C-l" 'iimage-recenter)
> +    (define-key map "\C-l" 'iimage-recenter-top-bottom)
>      map)
>    "Keymap used in `iimage-mode'.")

[...]

> +(defun iimage-recenter-top-bottom (&optional arg)
> +  "Re-draw images and call `recenter-top-bottom' with ARG."
> +  (interactive "P")
> +  (iimage-mode-buffer nil)
> +  (iimage-mode-buffer t)
> +  (recenter-top-bottom arg))

I don't think this is necessary -- instead iimage-recenter should just
call recenter-top-bottom.  I've now made this change on the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2019-06-24 16:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07 17:58 bug#27610: iimage mode patch =?UTF-8?Q?D=C3=B6ring, ?= Arne Frederic Maria
2019-06-24 16:25 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3k1dbrlw2.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=27610@debbugs.gnu.org \
    --cc==?UTF-8?Q?D=C3=B6ring@debbugs.gnu.org \
    --cc=arne.doering@rwth-aachen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.