From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dima Kogan <dima@secretsauce.net>
Cc: 18241@debbugs.gnu.org
Subject: bug#18241: 24.4.50; [PATCH] I can now highlight-lines-matching-regexp from isearch
Date: Wed, 26 Jun 2019 00:32:03 +0200 [thread overview]
Message-ID: <m3k1d9uwik.fsf@gnus.org> (raw)
In-Reply-To: <87sil4uhlw.fsf@secretsauce.net> (Dima Kogan's message of "Sun, 10 Aug 2014 15:04:11 -0700")
Dima Kogan <dima@secretsauce.net> writes:
> Before this patch it was possible to 'M-s h r' during an isearch to
> highlight the regexp being sought. This patch adds similar functionality
> for matching lines with 'M-s h l'. This patch moves the previous 'M-s h
> r' isearch functionality into a macro, and then calls this macro
> separately for the regex and line cases.
Hm... Is that a feature that would be used a lot? It's a somewhat
awkward interface and keystroke, I think.
But here's some comments on the code:
> +(defmacro isearch--hi-lock (hi-lock-form)
> + "Backend for isearch-highlight-*. Does all the setup work, and
> +evaluates the given `hi-lock-form' to actually invoke the
> +highlighting function"
[...]
> + (eval ,hi-lock-form))
I think this should be a function that should just take a function to
call that takes the parameters required.
And if this is something we want, it needs a NEWS entry and
documentation updates.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-06-25 22:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-10 22:04 bug#18241: 24.4.50; [PATCH] I can now highlight-lines-matching-regexp from isearch Dima Kogan
2019-06-25 22:32 ` Lars Ingebrigtsen [this message]
2019-06-25 22:58 ` Dima Kogan
2019-06-26 13:49 ` Lars Ingebrigtsen
2019-06-28 19:12 ` Juri Linkov
2019-06-30 18:08 ` Dima Kogan
2019-06-30 21:12 ` Juri Linkov
2019-07-01 3:09 ` Dima Kogan
2019-07-01 14:08 ` Eli Zaretskii
2019-07-04 1:31 ` Dima Kogan
2019-07-13 7:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k1d9uwik.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=18241@debbugs.gnu.org \
--cc=dima@secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.