?\ vs. ?\s

?\ vs. ?\s

[Juanma Barranquero]

Will everyone get the willies, hate my guts and burn little voodoo
dolls of yours truly if I replace many/most uses of "? " (as character
constant, not end of question followed by space :) and "?\ " with
"?\s"?

(I seem to hear the sound of arteries going "pop"... Time passes)

Much as I'd like to hear "no" to the first question, I'd assume a
resounding "yes". So...

Will someone get pissed if I change uses like:

  (eq ?\  cur-char)

i.e., "?\ " followed by another space?  I seem to remember there were
also one or two instances of

  ?\ 

("?\ " followed by end of line), but I'm unable to find them now.

-- 
                    /L/e/k/t/u

Re: ?\ vs. ?\s

[Kim F. Storm]

Juanma Barranquero <lekktu@gmail.com> writes:

> Will everyone get the willies, hate my guts and burn little voodoo
> dolls of yours truly if I replace many/most uses of "? " (as character
> constant, not end of question followed by space :) and "?\ " with
> "?\s"?
>
> (I seem to hear the sound of arteries going "pop"... Time passes)
>
> Much as I'd like to hear "no" to the first question, I'd assume a
> resounding "yes". So...

YES.

However, be careful not to change code which is supposed to be
used on other emacsen too...

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: ?\ vs. ?\s

[Juanma Barranquero]

> > Much as I'd like to hear "no" to the first question, I'd assume a
> > resounding "yes". So...
> 
> YES.

Humm. Yes meaning "OK to change" or yes meaning "Not OK" to change?
Because in my question, "yes" meant "yes, I'm gonna be very pissed if
you change it" :)

> However, be careful not to change code which is supposed to be
> used on other emacsen too...

That's the usual problem. As I see it:

 - OK to change:
   lisp/* (non-recursive)
   lisp/calc/*
   lisp/calendar/*
   lisp/emacs-lisp/*
   lisp/emulation/*
   lisp/international/*
   lisp/language/*
   lisp/net/* except lisp/net/tramp*
   lisp/obsolete/*
   lisp/play/*
   lisp/term/*
   lisp/toolbar/*
   lisp/url/*

 - Not OK to change:
   lisp/eshell/*
   lisp/gnus/*
   lisp/mh-e/*
   lisp/net/tramp*

 - Not sure:
   lisp/mail/*
   lisp/progmodes/* (in particular cc-*, ada*, idlw*)
   lisp/textmodes/* ("       "     artist, *spell, org, reftex*) 

-- 
                    /L/e/k/t/u

Re: ?\ vs. ?\s

[Juanma Barranquero]

> Humm. Yes meaning "OK to change" or yes meaning "Not OK" to change?
> Because in my question, "yes" meant "yes, I'm gonna be very pissed if
> you change it" :)

Or did you mean: yes to change "?\  ", no to change other "?\ "?

Because, after taking a look at it, many or most uses are "?\  ", so
it doesn't really pay to change ones and not the others...

-- 
                    /L/e/k/t/u

Re: ?\ vs. ?\s

[Kim F. Storm]

Juanma Barranquero <lekktu@gmail.com> writes:

>> Humm. Yes meaning "OK to change" or yes meaning "Not OK" to change?
>> Because in my question, "yes" meant "yes, I'm gonna be very pissed if
>> you change it" :)
>
> Or did you mean: yes to change "?\  ", no to change other "?\ "?
>
> Because, after taking a look at it, many or most uses are "?\  ", so
> it doesn't really pay to change ones and not the others...

IMO, we should change all of them, but is this really the time?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: ?\ vs. ?\s

[Juanma Barranquero]

On 6/29/05, Kim F. Storm <storm@cua.dk> wrote:

> IMO, we should change all of them, but is this really the time?

Release-wise? That's not a destabilizing change, I think... And
certainly is not a new feature ;-)

-- 
                    /L/e/k/t/u

Re: ?\ vs. ?\s

[Juanma Barranquero]

> Release-wise? That's not a destabilizing change, I think... And
> certainly is not a new feature ;-)

Anyway, I've changed space constants belonging to this two groups:

  ?\ ; this comment is here to protect from end of line
  ?\ ?\t  ; no room between the space constant and the next sexp

All in all that's less than ten files changed. Let's hope no one gets pissed.

-- 
                    /L/e/k/t/u

Re: ?\ vs. ?\s

[Kim F. Storm]

Juanma Barranquero <lekktu@gmail.com> writes:

> On 6/29/05, Kim F. Storm <storm@cua.dk> wrote:
>
>> IMO, we should change all of them, but is this really the time?
>
> Release-wise?

yes, but if you have the time, go ahead...

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: ?\ vs. ?\s

[Richard M. Stallman]

    > Or did you mean: yes to change "?\  ", no to change other "?\ "?
    >
    > Because, after taking a look at it, many or most uses are "?\  ", so
    > it doesn't really pay to change ones and not the others...

    IMO, we should change all of them, but is this really the time?

For fixing minor flaws, now's a fine time.

Re: ?\ vs. ?\s

[Richard M. Stallman]

    Will everyone get the willies, hate my guts and burn little voodoo
    dolls of yours truly if I replace many/most uses of "? " (as character
    constant, not end of question followed by space :) and "?\ " with
    "?\s"?

That would be an improvement, but not a major one.

There are several recent bug reports that need debugging.  If you
could debug and fix a few of them, it would contribute more
than improving these details.

Re: ?\ vs. ?\s

[Juanma Barranquero]

> On 6/29/05, Richard M. Stallman <rms@gnu.org> wrote:

> That would be an improvement, but not a major one.

I know. Even so, "?\ " pisses me a lot.

> There are several recent bug reports that need debugging.  If you
> could debug and fix a few of them, it would contribute more
> than improving these details.

I usually try to debug and fix problems I know enough about. For
example, I'm *quite* interested in receiving input (particularly your
input, as there's a legal question) about this problem with image
libraries on Windows, so I can finish the thing and get rid of it:

http://lists.gnu.org/archive/html/emacs-devel/2005-06/msg00891.html
http://lists.gnu.org/archive/html/emacs-devel/2005-06/msg01320.html

I tend to assume that preventing crashing is important enough, even on
Windows...

-- 
                    /L/e/k/t/u