From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Patch for user-emacs-directory Date: Sat, 02 Jun 2007 21:26:17 -0600 Message-ID: References: Reply-To: tromey@redhat.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1180842465 22247 80.91.229.12 (3 Jun 2007 03:47:45 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2007 03:47:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 03 05:47:44 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Huh49-0007cp-K9 for ged-emacs-devel@m.gmane.org; Sun, 03 Jun 2007 05:47:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Huh49-0006bn-6A for ged-emacs-devel@m.gmane.org; Sat, 02 Jun 2007 23:47:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Huh46-0006ZD-G1 for emacs-devel@gnu.org; Sat, 02 Jun 2007 23:47:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Huh45-0006Uh-32 for emacs-devel@gnu.org; Sat, 02 Jun 2007 23:47:37 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Huh44-0006UY-Se for emacs-devel@gnu.org; Sat, 02 Jun 2007 23:47:36 -0400 Original-Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Huh44-0001Th-0l; Sat, 02 Jun 2007 23:47:36 -0400 Original-Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l533lZ3e004334; Sat, 2 Jun 2007 23:47:35 -0400 Original-Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l533lZVE030107; Sat, 2 Jun 2007 23:47:35 -0400 Original-Received: from opsy.redhat.com (ton.toronto.redhat.com [172.16.14.15]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l533lYF4017031; Sat, 2 Jun 2007 23:47:34 -0400 Original-Received: by opsy.redhat.com (Postfix, from userid 500) id D103C888393; Sat, 2 Jun 2007 21:26:17 -0600 (MDT) X-Attribution: Tom In-Reply-To: (Eli Zaretskii's message of "Sun\, 03 Jun 2007 06\:09\:41 +0300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.990 (gnu/linux) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72096 Archived-At: >>>>> "Eli" == Eli Zaretskii writes: Eli> You've removed quite a few of the calls to convert-standard-filename, Eli> which I think is wrong. Perhaps you thought that it exists only for Eli> the MS-DOS port, but that assumption is false. I see this hunk: - ((file-directory-p (convert-standard-filename "~/.emacs.d/")) - (convert-standard-filename - (expand-file-name "completions" "~/.emacs.d/"))) + ((file-directory-p user-emacs-directory) + (expand-file-name "completions" user-emacs-directory)) I'm happy to reword this, but can you explain how this change can cause failures? Tom