bug#434: Minor Enhancement: Toggle narrowing/widen a function region and all

bug#434: Minor Enhancement: Toggle narrowing/widen a function region and all

[Kazuo YAGI]

I'd like to suggest a minor enhancement below.

This is to let you toggle narrowing/widen a function region and all
when editing a source code.

This works with C-s, M-%. M-x replace-string, M-x occur, etc ...

I think it make us easy to search/replace a word within a function.
And it is for not to jump over a function if you want to edit it only.

If you will, would you comment about this minor enhancement and tell me
which *.el is suitable for adding it?

Thanks for reading,
- Kazuo

;;; In GNU Emacs 22.1.1 (i686-pc-linux-gnu)
;;;  of 2008-05-09 on milia
;;; Windowing system distributor `The X.Org Foundation', version 11.0.10400090

;;; This is to let you toggle narrowing/widen a function region and all
;;; when editing a source code.

(defvar toggle-narrowing-function-and-all-p nil)

(defun toggle-narrowing-function-and-all ()
  (setq toggle-narrowing-function-and-all-p (not toggle-narrowing-function-and-all-p)))

(defun toggle-narrowing-function ()
  (interactive)
  (toggle-narrowing-function-and-all)
  (save-excursion
    (if toggle-narrowing-function-and-all-p
        (progn
          (next-line)
          (beginning-of-defun)
          (let ((beg)(end))
            (setq beg (point))
            (end-of-defun)
            (setq end (point))
            (narrow-to-region beg end)
            (count-lines-region beg end)))
      (widen))))

bug#434: Minor Enhancement: Toggle narrowing/widen a function region and all

[Lars Magne Ingebrigtsen]

Kazuo YAGI <kyagi@miraclelinux.com> writes:

> This is to let you toggle narrowing/widen a function region and all
> when editing a source code.
>
> This works with C-s, M-%. M-x replace-string, M-x occur, etc ...
>
> I think it make us easy to search/replace a word within a function.
> And it is for not to jump over a function if you want to edit it only.

I think it's an interesting idea.  Narrowing to the current function to
search around in it (especially when refactoring) is something that I
often do "manually", so having a handy keystroke for it would be nice, I
think.

`C-x n f', for instance, to toggle narrowing to the current function.

Opinions?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#434: Minor Enhancement: Toggle narrowing/widen a function regionand all

[Drew Adams]

> Narrowing to the current function to search around in it
> (especially when refactoring) is something that I often do
> "manually", so having a handy keystroke for it would 
> be nice, I think.
> 
> `C-x n f', for instance, to toggle narrowing to the current function.
> 
> Opinions?

YAGNI.  `narrow-to-defun' is `C-x n d'.  We don't need a toggle for each
narrowing command.  And certainly not another key binding.

This is the kind of thing that any user can do, if desired.  There are lots of
commands that some users might want to bind.  It is trivial for a user to do so.
No need for Emacs to do this by default.  One opinion.

bug#434: Minor Enhancement: Toggle narrowing/widen a function regionand all

[Chong Yidong]

"Drew Adams" <drew.adams@oracle.com> writes:

>> Narrowing to the current function to search around in it (especially
>> when refactoring) is something that I often do "manually", so having
>> a handy keystroke for it would be nice, I think.
>> 
>> `C-x n f', for instance, to toggle narrowing to the current function.
>> 
>> Opinions?
>
> YAGNI.  `narrow-to-defun' is `C-x n d'.  We don't need a toggle for
> each narrowing command.  And certainly not another key binding.

Agreed.

bug#434: Minor Enhancement: Toggle narrowing/widen a function regionand all

[Lars Magne Ingebrigtsen]

"Drew Adams" <drew.adams@oracle.com> writes:

> YAGNI.  `narrow-to-defun' is `C-x n d'. 

I didn't know about that command, which should be sufficient.  I'm
closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/