bug#19105: eww-save-history: use a customizable limit (eww-history-limit)

bug#19105: eww-save-history: use a customizable limit (eww-history-limit)

[Ivan Shmakov]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Package:  emacs
Severity: wishlist

	The limit on the number of eww-history entries enforced by
	eww-save-history is currently hard-coded.  Instead, it should be
	customizable, with an option not to enforce any limit at all.

	Please thus consider the patch MIMEd.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/diff, Size: 841 bytes --]

--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -65,6 +65,12 @@
   :group 'eww
   :type 'string)
 
+(defcustom eww-history-limit 50
+  "Maximum number of entries to retain in the history."
+  :version "25.1"
+  :group 'eww
+  :type '(choice (const :tag "Unlimited" nil)
+                 integer))
 (defcustom eww-use-external-browser-for-content-type
   "\\`\\(video/\\|audio/\\|application/ogg\\)"
   "Always use external browser for specified content-type."
@@ -1452,7 +1511,8 @@ Differences in #targets are ignored."
   (setq eww-data (list :title ""))
   ;; Don't let the history grow infinitely.  We store quite a lot of
   ;; data per page.
-  (when-let (tail (nthcdr 50 eww-history))
+  (when-let (tail (and eww-history-limit
+		       (nthcdr eww-history-limit eww-history)))
     (setcdr tail nil)))
 
 (defun eww-list-histories ()

bug#19105: eww-save-history: use a customizable limit (eww-history-limit)

[Lars Magne Ingebrigtsen]

Ivan Shmakov <ivan@siamics.net> writes:

> Package:  emacs
> Severity: wishlist
>
> 	The limit on the number of eww-history entries enforced by
> 	eww-save-history is currently hard-coded.  Instead, it should be
> 	customizable, with an option not to enforce any limit at all.
>
> 	Please thus consider the patch MIMEd.

Thanks; applied.  Could you send a doc fix for eww.texi?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#19105: eww-save-history: use a customizable limit (eww-history-limit)

[Ivan Shmakov]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>>>>> Ivan Shmakov <ivan@siamics.net> writes:

 >> Package: emacs Severity: wishlist

 >> The limit on the number of eww-history entries enforced by
 >> eww-save-history is currently hard-coded.  Instead, it should be
 >> customizable, with an option not to enforce any limit at all.

 >> Please thus consider the patch MIMEd.

 > Thanks; applied.  Could you send a doc fix for eww.texi?

	Sure; MIMEd.

-- 
FSF associate member #7257  np. Ghost Opera — Kamelot   … 3013 B6A0 230E 334A

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/diff, Size: 718 bytes --]

--- a/doc/misc/eww.texi
+++ b/doc/misc/eww.texi
@@ -126,6 +126,15 @@ @node Basics
 buffer @file{*eww history*}.  The history is lost when EWW is quit.
 If you want to remember websites you can use bookmarks.
 
+@vindex eww-history-limit
+  Along with the URLs visited, EWW also remembers both the rendered
+page (as it appears in the buffer) and its source.  This can take a
+considerable amount of memory, so EWW discards the history entries to
+keep their number within a set limit, as specified by
+@code{eww-history-limit}; the default being 50.  This variable could
+also be set to @code{nil} to allow for the history list to grow
+indefinitely.
+
 @findex eww-add-bookmark
 @findex eww-list-bookmarks
 @kindex b

bug#19105: eww-save-history: use a customizable limit (eww-history-limit)

[Lars Magne Ingebrigtsen]

Ivan Shmakov <ivan@siamics.net> writes:

>  > Thanks; applied.  Could you send a doc fix for eww.texi?
>
> 	Sure; MIMEd.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#19105: eww-save-history: use a customizable limit (eww-history-limit)

[Lars Magne Ingebrigtsen]

*And* I forgot to add Fixes: and bug# to the ChangeLogs.  I've been
hacking new features too many days in a row...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#19105: eww-save-history: use a customizable limit (eww-history-limit)

[Lars Magne Ingebrigtsen]

Uhm; I think I closed that bug report with the wrong version number...
But shouldn't matter.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#19105: eww-save-history: use a customizable limit (eww-history-limit)

[Ivan Shmakov]

notfixed  19105 24.5
fixed     19105 25.1
thanks

>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

 > Uhm; I think I closed that bug report with the wrong version
 > number...  But shouldn't matter.

	I guess the above should fix that.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A