From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string. Date: Wed, 07 Sep 2016 21:14:10 +0200 Message-ID: References: <20160907153014.15752-1-toke@toke.dk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1473275767 9313 195.159.176.226 (7 Sep 2016 19:16:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 7 Sep 2016 19:16:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 07 21:16:03 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhiKH-0001cd-Bv for ged-emacs-devel@m.gmane.org; Wed, 07 Sep 2016 21:16:01 +0200 Original-Received: from localhost ([::1]:42651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhiKF-00042h-8n for ged-emacs-devel@m.gmane.org; Wed, 07 Sep 2016 15:15:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhiK1-00040w-NF for emacs-devel@gnu.org; Wed, 07 Sep 2016 15:15:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhiJx-0001io-Ep for emacs-devel@gnu.org; Wed, 07 Sep 2016 15:15:44 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:43408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhiJx-0001bq-85 for emacs-devel@gnu.org; Wed, 07 Sep 2016 15:15:41 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1bhiJj-0001e8-9p; Wed, 07 Sep 2016 21:15:31 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAD1BMVEV6V3ePeZIzHzFsPV/N xNE3kbcKAAACcklEQVQ4jW2Ua5KsIAyFE3EBRFgAhrsAILMAadn/mu4B7fk1dltU5cuLcJBUz7Gp zuVQtSol9oGHVHmBbAF2E6kjDvzpH2hsOo35k64R6grotNe52qg98qUwLjuAMBZ/xej7/TGYvyDu WGTEWK5w2/6YJzhnrVE6t7hJ/qH4BUYiNIvraq3sb8gETKZNn87sF1QvIkFvPWaAGX9BRBsxtn78 Aa446uhvqrd6J7zXPiJLaCvC9viA3j3cpIC3GWG0kl2EzapSBujHE0L7iiBMWn2Z8fcqYobp9U4F WdlTlCjiaYGf0XkAEEXyIUbhqz7JhvSBVKXuQscEfoLiHIvMVEy11E8cl3lb8zLHOEFn9dpbPbBR Z4a9rO0vQF68R4/irLXccoEhdqpoVwJJHB4RGHYzZu5LJbLPenNPVKg0K4KDpJCdZ+cIXVHxvkyA vJ30pBTLAuLLbT6fmRk1rAStpWW/Dz7qrRDfVudxc93yqZoCD9nqxdvZDkzpolRaqlkLytNWTVqy w/LuKaFWLSUV4eqc81uGp3mhpIm5nCn1Wqm4HgwFCW0mS2j/TMVXJkFVEc2UD5oSaBBCgmVgFCKs qZWN+LjDFJvNM5xvl1S0KiV0pwjJ8yJdUwiforhElF02TFqzEMSFE7rzVHECsIBRo9XgoGIRpM1Z bR7/1X6YgwXHRHJDXbMhiJruJLSXLiyeQ54aAiH1Sc9wcu3phP7aqoA26VklxytNYT52LQ/IuWlv MQ57bxaGvUBKTe88nqvweG5vhC5wWf6CRq+PvB+T3wdgg9vpVKEs+Go+XpCMVT0AlBXGaL8RhpAE e8Kk8Mvvpf8PQNSoasfZibwAAAAASUVORK5CYII= In-Reply-To: <20160907153014.15752-1-toke@toke.dk> ("Toke \=\?utf-8\?Q\?H\?\= \=\?utf-8\?Q\?\=C3\=B8iland-J\=C3\=B8rgensen\=22's\?\= message of "Wed, 7 Sep 2016 17:30:14 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207274 Archived-At: Toke H=C3=B8iland-J=C3=B8rgensen writes: > In some cases the output of url-cookie-generate-header can be multibyte, > which will trip the length check that was added at the end of > url-http-create-request. I think that test should be removed so that Emacs 25.1 can be released (with the same level of workingness that that function has in Emacs 24.4). It was a mistake to add that test to Emacs 25. And then these things can be worked on for the next release. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no