Re: syntax based indentation for SQL files (ELPA package proposal)

[Thomas Fitzsimmons <fitzsim@fitzsim.org>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> This patch looks like it has been applied in the wrong place.  Emacs
>> builtin code should not depend on an external package.  Why did you add
>> this change into emacs, rather than the package that defines
>> sqind-minor-mode ?
>
> It doesn't actually depend on sql-indent.  It just makes use of it
> when available.  Given that sql-indent is in GNU ELPA, I think this is
> perfectly acceptable (and I'm pretty sure we have other similar cases
> already in emacs.git, some of which for packages that aren't even in
> GNU ELPA).

Yes, EUDC's optional dependency on BBDB (which is in GNU ELPA now) is
another example.  I don't love it, but I've learned to live with it,
especially given that the BBDB maintainer prefers the current
arrangement.  At one point there was talk of resolving these
dependencies during the creation of Emacs release tarballs.

Thomas