Re: FIX: byte-code: Wrong type argument: number-or-marker-p, (+ -21)

[storm@cua.dk (Kim F. Storm)]

Jan Nieuwenhuizen <janneke@gnu.org> writes:

> storm@cua.dk (Kim F. Storm) writes:
> 
> > This is definitely better than before, but you still do not address
> > the issue whether the new setting for top should be top/left or
> > bottom/right relative, ie. whether the new top value should be (+ INT)
> > or (- INT) if the old settings had that format (rather than an
> > integer).
> 
> Ah.  I assumed this:
> 
>     `((top . ,(+ top (* lines char-height))))
> 
> to be correct, and the value of TOP wrong if not an INT, but you're
> suggesting something like:
> 
>     `((top . ,((if (consp top)
>                    (cond ((eq '+ (car top))
>                           (list '+ (+ (cadr top) (* lines char-height))))
>                          ((eq '- (car top))
>                           (list '- (- (cadr top) (* lines char-height))))
>                          (t 0))
>                  ,(+ top (* lines char-height))))))

Exactly (but the , in the last line isn't needed).

> 
> but I'm not at all sure about the right arithmetic for (+/- INT) ...
> 

Me neither...   What do others think about this?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk