From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Strange test in xdisp.c Date: Tue, 16 Nov 2004 10:35:49 +0100 Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1100598338 25021 80.91.229.6 (16 Nov 2004 09:45:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 16 Nov 2004 09:45:38 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 16 10:45:21 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CTztp-0005KK-00 for ; Tue, 16 Nov 2004 10:45:21 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CU00V-0007ll-Im for ged-emacs-devel@m.gmane.org; Tue, 16 Nov 2004 04:52:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CTztc-0005gx-0W for emacs-devel@gnu.org; Tue, 16 Nov 2004 04:45:08 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CTztU-0005fM-MJ for emacs-devel@gnu.org; Tue, 16 Nov 2004 04:45:01 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CTztS-0005eW-PE for emacs-devel@gnu.org; Tue, 16 Nov 2004 04:44:59 -0500 Original-Received: from [212.88.64.25] (helo=mail-relay.sonofon.dk) by monty-python.gnu.org with smtp (Exim 4.34) id 1CTzkK-0007b0-07 for emacs-devel@gnu.org; Tue, 16 Nov 2004 04:35:32 -0500 Original-Received: (qmail 62906 invoked from network); 16 Nov 2004 09:35:30 -0000 Original-Received: from unknown (HELO kfs-l.imdomain.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 16 Nov 2004 09:35:30 -0000 Original-To: Stefan In-Reply-To: (Stefan's message of "Mon, 15 Nov 2004 23:50:07 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29919 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29919 Stefan writes: >> XFASTINT and a test for <= 0 seems a bit odd to me. > >> /* If bottom moved off end of frame, change mode line percentage. */ >> if (XFASTINT (w->window_end_pos) <= 0 >> && Z != IT_CHARPOS (it)) >> w-> update_mode_line = Qt; > > Hmm... indeed odd. I'd guess that the "== 0" part of "<= 0" is the one used > and the "< 0" part is basically never activated. I'd hope that if > window_end_pos had ever been something else than an integer, ENABLE_CHECKING > would have cought it (I always run with it). In most places, it is set like this: w->window_end_pos = make_number (...) And with USE_LSB_TAG, we have #define XFASTINT(x) XINT(x) so I guess ENABLE_CHECKING would not catch it in that case... All of this XFASTINT stuff seems bogus to me these days as we move towards USE_LSB_TAG on more platforms... -- Kim F. Storm http://www.cua.dk