From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Installing `struct buffer' patch (Was: Patch for fields of `struct buffer') Date: Sun, 13 Feb 2011 13:26:34 -0700 Message-ID: References: <4D47DFD4.1040108@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1297628813 9285 80.91.229.12 (13 Feb 2011 20:26:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 13 Feb 2011 20:26:53 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 13 21:26:48 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PoiWq-0005jQ-Vt for ged-emacs-devel@m.gmane.org; Sun, 13 Feb 2011 21:26:45 +0100 Original-Received: from localhost ([127.0.0.1]:40979 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PoiWq-00053e-9Z for ged-emacs-devel@m.gmane.org; Sun, 13 Feb 2011 15:26:44 -0500 Original-Received: from [140.186.70.92] (port=59437 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PoiWm-00053P-45 for emacs-devel@gnu.org; Sun, 13 Feb 2011 15:26:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PoiWk-0003N0-3Z for emacs-devel@gnu.org; Sun, 13 Feb 2011 15:26:39 -0500 Original-Received: from mx1.redhat.com ([209.132.183.28]:14542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PoiWj-0003Ms-PG for emacs-devel@gnu.org; Sun, 13 Feb 2011 15:26:38 -0500 Original-Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1DKQZ40030552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 13 Feb 2011 15:26:35 -0500 Original-Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p1DKQZj9011274; Sun, 13 Feb 2011 15:26:35 -0500 Original-Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1DKQYHO026827; Sun, 13 Feb 2011 15:26:34 -0500 Original-Received: by opsy.redhat.com (Postfix, from userid 500) id 36FFF3781C7; Sun, 13 Feb 2011 13:26:34 -0700 (MST) X-Attribution: Tom In-Reply-To: (Richard Stallman's message of "Sat, 12 Feb 2011 18:28:08 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135970 Archived-At: Tom> Do you still object to me installing the `struct buffer' macro Tom> change on the trunk? RMS> I don't object. I am going to check my patch in tomorrow. It may break some builds that I cannot test. However, in all cases, the fix is simple. The patch renames the fields of `struct buffer', so when you see an error arising from `something->field', you can simply change that to read `B_ (something, field)'. Please do not change any code to use `BUFFER_INTERNAL_FIELD'. thanks, Tom