From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.bugs Subject: bug#23561: epg tests are (almost) always skipped Date: Tue, 17 May 2016 17:48:42 +0900 Message-ID: References: <4nwpmtfb9p.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1463475032 8543 80.91.229.3 (17 May 2016 08:50:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 May 2016 08:50:32 +0000 (UTC) Cc: 23561@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 17 10:50:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b2aho-0006If-JX for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 May 2016 10:50:20 +0200 Original-Received: from localhost ([::1]:49335 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2aho-0007HQ-0I for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 May 2016 04:50:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2ahe-00074T-Jo for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 04:50:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2ahY-0001hN-EC for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 04:50:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2ahY-0001gw-Aw for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 04:50:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b2ahW-0004PO-8n for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 04:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daiki Ueno Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 May 2016 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23561 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23561-submit@debbugs.gnu.org id=B23561.146347494316871 (code B ref 23561); Tue, 17 May 2016 08:50:02 +0000 Original-Received: (at 23561) by debbugs.gnu.org; 17 May 2016 08:49:03 +0000 Original-Received: from localhost ([127.0.0.1]:54658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2agZ-0004O3-Dn for submit@debbugs.gnu.org; Tue, 17 May 2016 04:49:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2agX-0004NW-Cx for 23561@debbugs.gnu.org; Tue, 17 May 2016 04:49:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2agN-0001Pl-6Y for 23561@debbugs.gnu.org; Tue, 17 May 2016 04:48:56 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2agN-0001PV-30 for 23561@debbugs.gnu.org; Tue, 17 May 2016 04:48:51 -0400 Original-Received: from du-a.org ([219.94.251.20]:38316 helo=localhost.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b2agK-0003Fs-U4; Tue, 17 May 2016 04:48:49 -0400 In-Reply-To: <4nwpmtfb9p.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 17 May 2016 02:29:06 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118341 Archived-At: --=-=-= Content-Type: text/plain Glenn Morris writes: > Since f93d669a, epg-gpg-program defaults to gpg2 if present (which it is > on most systems, I guess). epg-tests-gpg-usable, however, requires gpg > version 1 (in the 'require-passphrase case, which is what every test in > epg-tests uses). As a result, every test in epg-tests is skipped on a > system with "gpg2" present (even if "gpg" is also present). I am actually not sure how to cleanly solve this issue, but as long as "gpg2" is GnuPG 2.0, the attached patch should work around the issue (if "gpg2" is upgraded to 2.1, another issue will arise, though). Regards, -- Daiki Ueno --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Adjust-to-epg-configuration-deprecation.patch >From d43d3e66b5582c1e5b8e61eaf7f3ac8866c997a4 Mon Sep 17 00:00:00 2001 From: Daiki Ueno Date: Tue, 17 May 2016 17:46:31 +0900 Subject: [PATCH] Adjust to epg-configuration deprecation. * test/lisp/epg-tests.el (epg-tests-gpg-usable): Use `epg-find-configuration' instead of deprecated `epg-configuration'. --- test/lisp/epg-tests.el | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/test/lisp/epg-tests.el b/test/lisp/epg-tests.el index 4a31797..06e6f25 100644 --- a/test/lisp/epg-tests.el +++ b/test/lisp/epg-tests.el @@ -30,16 +30,20 @@ epg-tests-data-directory (expand-file-name "data/epg" (getenv "EMACS_TEST_DIRECTORY")) "Directory containing epg test data.") +;; If a passphrase is required, we can only use GnuPG 1.x, as GnuPG +;; 2.0 or later involves gpg-agent, which prevents injecting +;; passphrase reliably. (defun epg-tests-gpg-usable (&optional require-passphrase) - (and (executable-find epg-gpg-program) - (condition-case nil - (progn - (epg-check-configuration (epg-configuration)) - (if require-passphrase - (string-match "\\`1\\." - (cdr (assq 'version (epg-configuration)))) - t)) - (error nil)))) + (let ((config (epg-find-configuration 'OpenPGP))) + (and config + (condition-case nil + (progn + (epg-check-configuration config) + (if require-passphrase + (string-match "\\`1\\." + (cdr (assq 'version config))) + t)) + (error nil))))) (defun epg-tests-passphrase-callback (_c _k _d) ;; Need to create a copy here, since the string will be wiped out -- 2.5.5 --=-=-=--