From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Search for image from the beginning of the fetched buffer Date: Mon, 24 Jul 2017 17:30:06 +0200 Message-ID: References: <87r2x8u6jr.fsf@omecha.info> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1500910269 17299 195.159.176.226 (24 Jul 2017 15:31:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Jul 2017 15:31:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Emacs Devel To: gjadi@omecha.info (=?utf-8?Q?Gr=C3=A9goire?= Jadi) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 24 17:30:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZfJs-0003eN-7Y for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 17:30:52 +0200 Original-Received: from localhost ([::1]:55443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZfJw-0003k7-Cw for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 11:30:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZfJN-0003k1-VN for emacs-devel@gnu.org; Mon, 24 Jul 2017 11:30:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZfJK-0001Ar-Sm for emacs-devel@gnu.org; Mon, 24 Jul 2017 11:30:21 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:59805) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZfJK-000183-MJ for emacs-devel@gnu.org; Mon, 24 Jul 2017 11:30:18 -0400 Original-Received: from cm-84.209.243.26.getinternet.no ([84.209.243.26] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1dZfJ9-00075F-4l; Mon, 24 Jul 2017 17:30:09 +0200 In-Reply-To: <87r2x8u6jr.fsf@omecha.info> (=?utf-8?Q?=22Gr=C3=A9goire?= Jadi"'s message of "Sat, 22 Jul 2017 12:09:28 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216966 Archived-At: gjadi@omecha.info (Gr=C3=A9goire Jadi) writes: > After a bit of lurking, I found out that the image where correctly > restored from the cache, because it starts to parse at position 1. > However, the position in the buffer in `shr-image-fetched' is something > else >1. I haven't figured out why the position isn't right (I suspect > something in `url-file'). > > The fix I've found so far is to force position 1 in `shr-image-fetched'. > I've also disabled multibyte because `shr-get-image-data' does it, but > it might be unnecessary. > Patch below. Thanks; applied (but I left the multibyte stuff out -- it shouldn't be necessary). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no