From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] master aa5513d 1/7: excorporate-diary: Always use diary-fancy-display
Date: Mon, 17 Jun 2019 18:18:16 -0400 [thread overview]
Message-ID: <m3h88nlutz.fsf@fitzsim.org> (raw)
In-Reply-To: <jwvblyxw3h0.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 16 Jun 2019 18:56:02 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Thanks for reviewing. Yeah, I didn't like having to do that but the
>> stock alternative, diary-simple-display, is broken.
>
> FWIW, the default is already the fancy display:
>
> % grep diary-display-function **/*.el
> [...]
> lisp/calendar/diary-lib.el:(defcustom diary-display-function #'diary-fancy-display
>
> So if the user gets broken behavior it's presumably because of
> a specific choice in its config, I think it's OK to just explain the
> reason to the user without trying to impose a particular fix.
Good point, pushed a change so that only the warning is issued.
Thomas
prev parent reply other threads:[~2019-06-17 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190614211218.5886.59920@vcs0.savannah.gnu.org>
[not found] ` <20190614211219.59B5721012@vcs0.savannah.gnu.org>
2019-06-15 10:32 ` [elpa] master aa5513d 1/7: excorporate-diary: Always use diary-fancy-display Stefan Monnier
2019-06-15 13:13 ` Thomas Fitzsimmons
2019-06-16 22:56 ` Stefan Monnier
2019-06-17 22:18 ` Thomas Fitzsimmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3h88nlutz.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.