bug#30527: 26.0.91; describe-face does not mention :package-version

bug#30527: 26.0.91; describe-face does not mention :package-version

[Basil L. Contovounesios]

Severity: wishlist

After evaluating the following:

  (defgroup my-group nil
    "Custom group.")

  (defcustom my-var nil
    "User option."
    :package-version '(my-group . "0.1"))

  (defface my-face '((t :inherit default))
    "Custom face."
    :package-version '(my-group . "0.1"))

C-h v my-var RET then reports, "This variable was introduced, or its
default value was changed, in version 0.1 of the my-group package."

M-x describe-face RET my-face RET, on the other hand, makes no such
comment.  Given that defface is documented as accepting the same
keywords as defcustom, I think it would be nice if describe-face were
consistent with describe-variable in this regard.

-- 
Basil

In GNU Emacs 26.0.91 (build 5, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2018-02-18 built on thunk
Repository revision: 36e729f06cddd2a02fba15516f43f4c1a53bab55
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description:	Debian GNU/Linux testing (buster)

bug#30527: 26.0.91; describe-face does not mention :package-version

[Lars Ingebrigtsen]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Severity: wishlist
>
> After evaluating the following:
>
>   (defgroup my-group nil
>     "Custom group.")
>
>   (defcustom my-var nil
>     "User option."
>     :package-version '(my-group . "0.1"))
>
>   (defface my-face '((t :inherit default))
>     "Custom face."
>     :package-version '(my-group . "0.1"))
>
> C-h v my-var RET then reports, "This variable was introduced, or its
> default value was changed, in version 0.1 of the my-group package."
>
> M-x describe-face RET my-face RET, on the other hand, makes no such
> comment.  Given that defface is documented as accepting the same
> keywords as defcustom, I think it would be nice if describe-face were
> consistent with describe-variable in this regard.

Makes sense.  I've now added this to the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#30527: 26.0.91; describe-face does not mention :package-version

[Andy Moreton]

On Sun 14 Jul 2019, Lars Ingebrigtsen wrote:

> Makes sense.  I've now added this to the Emacs trunk.

This fails to build on 64bit MSYS2 (Windows) when dumping:

Loading faces...
(require subr-x) while preparing to dump
make[1]: *** [Makefile:584: emacs.pdmp] Error 127
make[1]: Leaving directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2/src'
make: *** [Makefile:424: src] Error 2

bug#30527: 26.0.91; describe-face does not mention :package-version

[Lars Ingebrigtsen]

Andy Moreton <andrewjmoreton@gmail.com> writes:

> On Sun 14 Jul 2019, Lars Ingebrigtsen wrote:
>
>> Makes sense.  I've now added this to the Emacs trunk.
>
> This fails to build on 64bit MSYS2 (Windows) when dumping:
>
> Loading faces...
> (require subr-x) while preparing to dump
> make[1]: *** [Makefile:584: emacs.pdmp] Error 127
> make[1]: Leaving directory
> '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2/src'
> make: *** [Makefile:424: src] Error 2

I've now reverted the patch; I'll rework it to not use subr-x, I
guess...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no