From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Again: `find-lisp-default-directory-predicate' and symlinks Date: Wed, 28 Feb 2007 10:47:02 +0100 Message-ID: References: <35413.128.165.123.18.1172619471.squirrel@webmail.lanl.gov> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1172656017 2815 80.91.229.12 (28 Feb 2007 09:46:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 28 Feb 2007 09:46:57 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 28 10:46:50 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HMLOb-0003qe-Gp for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2007 10:46:49 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HMLOb-0002tp-V2 for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2007 04:46:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HMLO2-0002YK-8o for emacs-devel@gnu.org; Wed, 28 Feb 2007 04:46:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HMLO1-0002Xw-3h for emacs-devel@gnu.org; Wed, 28 Feb 2007 04:46:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HMLO0-0002Xq-V4 for emacs-devel@gnu.org; Wed, 28 Feb 2007 04:46:13 -0500 Original-Received: from pfepb.post.tele.dk ([195.41.46.236]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HMLO0-0004Yr-HK for emacs-devel@gnu.org; Wed, 28 Feb 2007 04:46:12 -0500 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepb.post.tele.dk (Postfix) with SMTP id D0EC1A5009A for ; Wed, 28 Feb 2007 10:46:10 +0100 (CET) In-Reply-To: <35413.128.165.123.18.1172619471.squirrel@webmail.lanl.gov> (Stuart D. Herring's message of "Tue\, 27 Feb 2007 15\:37\:51 -0800 \(PST\)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.94 (gnu/linux) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67011 Archived-At: "Stuart D. Herring" writes: > $ cvs update tells me that my 1-line find-lisp.el bugfix mentioned at > > http://lists.gnu.org/archive/html/emacs-devel/2006-08/msg00262.html > > has never been applied, nor was it rejected in a reply email (that I saw). > May I have it looked at again before the release? Here's the original posting: Isn't this trivial patch needed to get `find-lisp-default-directory-predicate' to actually detect symlinks? (See `find-lisp-default-file-predicate' for comparison.) If so, please install. Thanks, Davis *** find-lisp.el.~1.13.~ 2006-02-13 18:21:31.000000000 -0700 --- find-lisp.el 2006-08-07 16:52:21.000000000 -0600 *************** *** 96,102 **** (string= dir "..") ;; Skip directories which are symlinks ;; Easy way to circumvent recursive loops ! (file-symlink-p dir)))) (defun find-lisp-default-file-predicate (file dir) "True if FILE matches `find-lisp-regexp'. --- 96,102 ---- (string= dir "..") ;; Skip directories which are symlinks ;; Easy way to circumvent recursive loops ! (file-symlink-p (expand-file-name dir parent))))) (defun find-lisp-default-file-predicate (file dir) "True if FILE matches `find-lisp-regexp'. -- Kim F. Storm http://www.cua.dk