From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#6096: 24.0.50; code error in accept-change-group Date: Wed, 21 Sep 2011 21:52:05 +0200 Message-ID: References: <87fx28sqna.fsf@fh-trier.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1316635015 990 80.91.229.12 (21 Sep 2011 19:56:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 21 Sep 2011 19:56:55 +0000 (UTC) Cc: 6096@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 21 21:56:51 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R6SuY-0002FG-Ru for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Sep 2011 21:56:50 +0200 Original-Received: from localhost ([::1]:36841 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6SuY-0001sB-FX for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Sep 2011 15:56:50 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:40460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6SuV-0001s2-5q for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 15:56:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6SuU-00034u-5c for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 15:56:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6SuU-00034q-2I for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 15:56:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R6Suk-0003ST-99 for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2011 15:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2011 19:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6096 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6096-submit@debbugs.gnu.org id=B6096.131663497013220 (code B ref 6096); Wed, 21 Sep 2011 19:57:02 +0000 Original-Received: (at 6096) by debbugs.gnu.org; 21 Sep 2011 19:56:10 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6Stu-0003RB-Ct for submit@debbugs.gnu.org; Wed, 21 Sep 2011 15:56:10 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6Stq-0003Qs-6j for 6096@debbugs.gnu.org; Wed, 21 Sep 2011 15:56:07 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R6StT-0004r4-3E; Wed, 21 Sep 2011 21:55:43 +0200 In-Reply-To: <87fx28sqna.fsf@fh-trier.de> (Andreas Politz's message of "Mon, 03 May 2010 21:59:21 +0200") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Colder's _Heat_: "The Winter's Fields" X-MailScanner-ID: 1R6StT-0004r4-3E MailScanner-NULL-Check: 1317239743.20269@dcJ1Q/aS/SwJgP9yjkXbuA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 21 Sep 2011 15:57:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51588 Archived-At: Andreas Politz writes: > (defun accept-change-group (handle) > "Finish a change group made with `prepare-change-group' (which see). > This finishes the change group by accepting its changes as final." > (dolist (elt handle) > (with-current-buffer (car elt) > (if (eq elt t) > (setq buffer-undo-list t))))) > > I think this should be more like `(eq (cdr elt) t)', it should > redeactivate undo. This test can not possibly succeed anyway. Yes, `(eq elt t)' can't possibly be true, since `elt' is a list. `elt is something on the form (cons (current-buffer) buffer-undo-list) so I think probably `(eq (cdr elt) t)' is correct, as noted. Does anybody have any comments, or should I just apply that fix? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/