From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: trunk r113947: * image.c: Fix animation cache signature memory leak. Date: Mon, 19 Aug 2013 19:04:43 +0200 Message-ID: References: <521244F0.3060508@cs.ucla.edu> <521246C4.3070004@cs.ucla.edu> <52124E37.2080709@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376931911 13083 80.91.229.3 (19 Aug 2013 17:05:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Aug 2013 17:05:11 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 19 19:05:13 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VBStC-0003VW-6R for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2013 19:05:10 +0200 Original-Received: from localhost ([::1]:44147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBStB-0004lV-BE for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2013 13:05:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBSt4-0004gT-3Y for emacs-devel@gnu.org; Mon, 19 Aug 2013 13:05:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBSsy-0004m4-RO for emacs-devel@gnu.org; Mon, 19 Aug 2013 13:05:02 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:60046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBSsy-0004lp-Ln for emacs-devel@gnu.org; Mon, 19 Aug 2013 13:04:56 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VBSsl-0000Ko-R0; Mon, 19 Aug 2013 19:04:43 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAKlBMVEWUfU81LyOpkVz++/E8 NSJOQRjgyJD+/vkNBAEpGQJfUCb15sN3YzrHrXElJF4bAAACWklEQVQ4jXWTP2vbUBTFL1qrDhkD GYQCWWpPgnjQlOIMLhn9hpgOhoA62Jo0aPAXsPcarE5tQMvjbQF7EIWHaTOodyg2eEn1XXrve3qJ M+Rsuj+dc94fCU7eEJwh/kKlfrjBmfYRoSYQaA3w8cqBG12jwpsTeDPq9WOfJKVUlIYAHoROQEKs ZTmEkUJ+Cj2wQ5IsxXAAEsE7et0ahOiDpnm3ITEKAPzfIwvO47RpZW21MFnwJ8/ixKhpdgQav8Sa wWOeRVFcEUiNqelILhnCtsfEIibNP+XTcgXoDc9Za2M67OiwDNjbcR7F1pP6YMF5C/IZpaWHZAoB l4D+4EBWUdgkmQaeYoAXZt6zYFJV09DsHZT3YA15Hles8Q6pncGdNViQVOMAO7UDGTl4L1RfjcGB Jwriiiji9mq8rX0LDi2gdnJMxroGC7qmmWUBKpAMdPfBAXNgf1FtFe18pLt3xyANsdxKA8K9A7N1 kqYBgdoA7+kZVHS+QV3eGwd6h14LMoo6BCju+aIELWvzAsiB4vPIAN394sCaLoRBKa7gmkpc+4yv sKPEp5I+n2sqce1xku5CAt9KMYClUNB9SdoFvhwuxekKCi7ZPCeF4Je3RVHMoeAS224MgOXQguVI eXveSUbzELAW5JgT+EpZF2y4TLkB5XBgAWXh+96zAeXt6YrBoqB1aWqf8Zw/wkGxmhOYF4UYadri T/5zkK6IgxgsuP5dntGCfPMzOcAW+di7DEyOILBoAbd8j+irqe3cGBiYlglyvBj0iyPAxKbwYZg1 tYCJG78Gi+JIFvwHud34//DiuGUAAAAASUVORK5CYII= X-Now-Playing: John Foxx's _Metamatic_: "No-One Driving" X-Hashcash: 1:23:130819:eggert@cs.ucla.edu::rxrm1lsXRKE6dZ3U:00000000000000000000000000000000000000000006BRL X-Hashcash: 1:23:130819:emacs-devel@gnu.org::mIzhdqyPbnX2bhih:000000000000000000000000000000000000000000iPkm In-Reply-To: <52124E37.2080709@cs.ucla.edu> (Paul Eggert's message of "Mon, 19 Aug 2013 09:56:23 -0700") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-MailScanner-ID: 1VBSsl-0000Ko-R0 MailScanner-NULL-Check: 1377536684.06093@OpI715+oIANQpxzrkgztgQ X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162889 Archived-At: Paul Eggert writes: > By the way, did you know that each animation signature > contains 4 KiB of wasted memory? It's ImageMagick > code that's wasting it. Dunno if that's worth tuning. I tried looking at the ImageMagick sources and it made my head swim. The signature function calls AquireString, which eventually calls AcquireMagickMemory, which manages a pool of memory. Probably to avoid having to call malloc a lot. But if that can be tuned, then it would probably be nice to get rid of the extra memory. But it might not make much difference. After all, we stick the wand into the cache, and the wand is going to be a lot bigger. Actually, calling the cache pruning function now and then would probably be a good idea? I'm not sure where it should be called from, though. The idle timer? -- (domestic pets only, the antidote for overdose, milk.) No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html