From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] xwidget updated (1d8b8a2 -> 5f46725) Date: Fri, 09 Jan 2015 21:12:39 +0100 Message-ID: References: <20141226164113.11620.38682@vcs.savannah.gnu.org> <831tnjlpts.fsf@gnu.org> <83k31ajvdz.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1420834394 3903 80.91.229.3 (9 Jan 2015 20:13:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 9 Jan 2015 20:13:14 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 09 21:13:07 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y9fve-0000X5-PJ for ged-emacs-devel@m.gmane.org; Fri, 09 Jan 2015 21:13:06 +0100 Original-Received: from localhost ([::1]:52067 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9fve-0002PO-24 for ged-emacs-devel@m.gmane.org; Fri, 09 Jan 2015 15:13:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9fva-0002PB-Lr for emacs-devel@gnu.org; Fri, 09 Jan 2015 15:13:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9fvZ-0008Bm-Uq for emacs-devel@gnu.org; Fri, 09 Jan 2015 15:13:02 -0500 Original-Received: from mx2.bahnhof.se ([213.80.101.12]:33797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9fvW-00088d-Ev; Fri, 09 Jan 2015 15:12:58 -0500 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx2-reinject (Postfix) with ESMTP id 99E4040782; Fri, 9 Jan 2015 21:12:56 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF4) Original-Received: from mf4.bahnhof.se ([127.0.0.1]) by localhost (mf4.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wwbPkakSqn7m; Fri, 9 Jan 2015 21:12:51 +0100 (CET) Original-Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf4.bahnhof.se (Postfix) with ESMTP id BAA923D77FA; Fri, 9 Jan 2015 21:12:50 +0100 (CET) Original-Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id 5498E529CA2; Fri, 9 Jan 2015 20:12:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Original-Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sv7Uo9-rDddK; Fri, 9 Jan 2015 21:12:39 +0100 (CET) Original-Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id C06F4529C9B; Fri, 9 Jan 2015 21:12:39 +0100 (CET) In-Reply-To: <83k31ajvdz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 29 Dec 2014 18:03:36 +0200") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 213.80.101.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181112 Archived-At: Eli Zaretskii writes: > >> > 5) xdisp.c:produce_xwidget_glyph needs to account for bidirectional >> > display in the same way produce_image_glyph does: swao the left and >> > right box edges, and populate the bidi members of struct glyph. > >> I havent thought about bidi at all. > > Just look at what produce_image_glyph does, it should tell you enough. > >> Do you have a simple test case [for bidi]? > > Type a few Arabic or Hebrew characters, then insert a widget, then > type some more Arabic or Hebrew. Try this both in a buffer that has > bidi-paragraph-direction set to nil and in a buffer that has it set to > left-to-right or right-to-left. I tried this briefly by opening the hello file and pasting an arabic hello string a couple of times. Stuff happens, but maybe not the correct stuff. It is hard for me to tell. Do you have a more precise test case? -- Joakim Verona