From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour Date: Mon, 17 Sep 2018 20:29:24 -0400 Message-ID: References: <20180915233623.2746.56778@vcs0.savannah.gnu.org> <20180915233624.2285320442@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1537230482 2162 195.159.176.226 (18 Sep 2018 00:28:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Sep 2018 00:28:02 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 18 02:27:58 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g23ry-0000R5-4T for ged-emacs-devel@m.gmane.org; Tue, 18 Sep 2018 02:27:58 +0200 Original-Received: from localhost ([::1]:37880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g23u4-0000Uk-Nc for ged-emacs-devel@m.gmane.org; Mon, 17 Sep 2018 20:30:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g23tU-0000UU-37 for emacs-devel@gnu.org; Mon, 17 Sep 2018 20:29:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g23tQ-00064k-Ny for emacs-devel@gnu.org; Mon, 17 Sep 2018 20:29:32 -0400 Original-Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]:43339) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g23tQ-00063t-I4 for emacs-devel@gnu.org; Mon, 17 Sep 2018 20:29:28 -0400 Original-Received: by mail-io1-xd31.google.com with SMTP id y10-v6so116868ioa.10 for ; Mon, 17 Sep 2018 17:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lt/lCax53gdLFgiMSgQbPU9NQl5nhG+GJ4jHX/V8w6E=; b=vNwE3tk1MKAl3xzIBA5tpTXGghTQjvFM+YwmQyOwhmWdNQObOqBDRDIwu1c+ofPxYm uqm92vEz7Njx6smVl/aqoOazqP7iZLN+R9oxM24xDV0D1fsDccmoQLuNvO/919UgIsdv cQioLR4LVbYUTrF0LuLg8kThjCXju8ajucF15ElRiAO/PdqWFicch2TFSeA8LyFeh3I5 JyHvxytV3sM8LcrNDCF9fqlKijtmT0Y2yaZdJULsapTK9AQUKqqNXSQJYEyZ7u1848Qg raF1gYUJDop41DGg+mRGJzcBI72mxni9XiURH4s93dcFNDsT2EYjlDs3fNi1tISEs8XF PPHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lt/lCax53gdLFgiMSgQbPU9NQl5nhG+GJ4jHX/V8w6E=; b=aNj+/v8qIGb4gaD+M2jpEtUyRnfLX9IYDgGQJNY9PC4AqjvCRSqfCVomxg0Of4ycaZ /wESVL/sjEX//w+UHsAkXxEkr9czKh2uoaKaf6E1arJBAYqXolBPLzFcT8hP0PIfdEqh GN+v3ytS3lCWZW8AmjjbxGOtn85iX+3w1K/Zhwk6i/EEjXu2SRgM8RC/wAKbYXbz27cF V6Vjl1q0/XcMUTXpOdUVph9ArekvCtf3O+2hrKHb9B1c/u++kcZzf/M3Wsmm9DHYLevt 3STHYAb0rdsz1ar491K+UFt80zI+fg6Qb68v5feFNdmJ/1BndAE8VkswiiTKWSokNBIP YKdQ== X-Gm-Message-State: APzg51CGoRb9ukzeAQhCtp1ETBeUr7Dc3j+lLGxx0poYT0gmD0i6j2nm x9md9e28sWGj7+rUTAocHnpwXAmJO9Q= X-Google-Smtp-Source: ANB0VdY+hCkaU1Bal7g5xFEHy/auZD+MbPHGGT/yBVBMvFDlUF9FHGPN6CDuRjL/ZMzkILy4Ff2xKQ== X-Received: by 2002:a6b:9444:: with SMTP id w65-v6mr22067932iod.275.1537230567469; Mon, 17 Sep 2018 17:29:27 -0700 (PDT) Original-Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id g129-v6sm3892242itg.16.2018.09.17.17.29.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Sep 2018 17:29:26 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 17 Sep 2018 11:06:20 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d31 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229924 Archived-At: Stefan Monnier writes: >> + ;; Just return nil if there is no advice, rather than signaling an >> + ;; error. >> + (condition-case nil >> + (ad-remove-advice symbol 'around function) >> + (error nil)) >> + (condition-case nil >> + (ad-activate symbol) >> + (error nil))) > > BTW, I just pushed a change which adds support for advice-member-p and > changes the above code to make use of it, in order to silence > fewer errors. > > It works in my tests, but could you check that it still works for you? Confirmed still working, thanks. Thomas