From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour
Date: Mon, 17 Sep 2018 20:29:24 -0400 [thread overview]
Message-ID: <m3fty7fy1n.fsf@fitzsim.org> (raw)
In-Reply-To: <jwva7og2p4r.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Mon, 17 Sep 2018 11:06:20 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> + ;; Just return nil if there is no advice, rather than signaling an
>> + ;; error.
>> + (condition-case nil
>> + (ad-remove-advice symbol 'around function)
>> + (error nil))
>> + (condition-case nil
>> + (ad-activate symbol)
>> + (error nil)))
>
> BTW, I just pushed a change which adds support for advice-member-p and
> changes the above code to make use of it, in order to silence
> fewer errors.
>
> It works in my tests, but could you check that it still works for you?
Confirmed still working, thanks.
Thomas
prev parent reply other threads:[~2018-09-18 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180915233623.2746.56778@vcs0.savannah.gnu.org>
[not found] ` <20180915233624.2285320442@vcs0.savannah.gnu.org>
2018-09-17 13:54 ` [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour Stefan Monnier
2018-09-17 14:12 ` Michael Albinus
2018-09-17 15:06 ` Stefan Monnier
2018-09-18 0:29 ` Thomas Fitzsimmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fty7fy1n.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.