From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#18131: 24.4.50; View-search-... skips all matches between (point) and edge of window Date: Wed, 26 Jun 2019 00:50:07 +0200 Message-ID: References: <878undtl18.fsf@secretsauce.net> <87bn77oboa.fsf@gnus.org> <87k2aoecg7.fsf@secretsauce.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="19779"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 18131@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 00:51:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfuHf-00052o-Fo for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 00:51:27 +0200 Original-Received: from localhost ([::1]:35634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfuHe-0001tn-I4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 18:51:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48458) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfuHM-0001sp-3t for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 18:51:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfuHH-00031r-NJ for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 18:51:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfuHF-0002yk-Og for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 18:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfuHF-0008Pb-KO for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 18:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 22:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18131 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18131-submit@debbugs.gnu.org id=B18131.156150301432245 (code B ref 18131); Tue, 25 Jun 2019 22:51:01 +0000 Original-Received: (at 18131) by debbugs.gnu.org; 25 Jun 2019 22:50:14 +0000 Original-Received: from localhost ([127.0.0.1]:33783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuGU-0008O0-CQ for submit@debbugs.gnu.org; Tue, 25 Jun 2019 18:50:14 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:58108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuGS-0008Nm-57 for 18131@debbugs.gnu.org; Tue, 25 Jun 2019 18:50:12 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfuGN-0005Jc-Ax; Wed, 26 Jun 2019 00:50:09 +0200 In-Reply-To: <87k2aoecg7.fsf@secretsauce.net> (Dima Kogan's message of "Sat, 24 Dec 2016 22:43:04 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161436 Archived-At: Dima Kogan writes: >>> - (move-to-window-line (if (< times 0) 0 -1))) >> >> If this was a design choice, then we should perhaps ask the person who >> designed it what it's all about... which isn't easy in this instance, >> since this is very old code. >> >> Does anybody have an opinion here? > > Can we revisit this? I think view-mode behaving like 'less' does would > be an improvement. After playing with it a bit, I think you're right -- the current behaviour seems really unobvious. I've applied your patch to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no