From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Please review: Small fix for window.c Date: Wed, 08 Mar 2006 16:52:54 +0100 Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1141833393 19208 80.91.229.2 (8 Mar 2006 15:56:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 8 Mar 2006 15:56:33 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 08 16:56:31 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FH108-0002J2-3h for ged-emacs-devel@m.gmane.org; Wed, 08 Mar 2006 16:55:00 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FH107-0007iD-Bx for ged-emacs-devel@m.gmane.org; Wed, 08 Mar 2006 10:54:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FH0zq-0007hL-Jv for emacs-devel@gnu.org; Wed, 08 Mar 2006 10:54:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FH0zn-0007el-40 for emacs-devel@gnu.org; Wed, 08 Mar 2006 10:54:41 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FH0zn-0007ei-18 for emacs-devel@gnu.org; Wed, 08 Mar 2006 10:54:39 -0500 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FH12e-0002nI-QP for emacs-devel@gnu.org; Wed, 08 Mar 2006 10:57:36 -0500 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepb.post.tele.dk (Postfix) with SMTP id 92130A50045 for ; Wed, 8 Mar 2006 16:54:36 +0100 (CET) Original-To: emacs-devel@gnu.org User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51372 Archived-At: Since any non-nil value for set-window-dedicated-p means window is dedicated, testing explicitly for Qt seems like a bug... *** window.c 28 Feb 2006 16:57:34 +0100 1.537 --- window.c 08 Mar 2006 16:49:11 +0100 *************** *** 2009,2015 **** `obj & 1' means consider only full-width windows. `obj & 2' means consider also dedicated windows. */ if (((XINT (obj) & 1) && !WINDOW_FULL_WIDTH_P (w)) ! || (!(XINT (obj) & 2) && EQ (w->dedicated, Qt)) /* Minibuffer windows are always ignored. */ || MINI_WINDOW_P (w)) break; --- 2009,2015 ---- `obj & 1' means consider only full-width windows. `obj & 2' means consider also dedicated windows. */ if (((XINT (obj) & 1) && !WINDOW_FULL_WIDTH_P (w)) ! || (!(XINT (obj) & 2) && !NILP (w->dedicated)) /* Minibuffer windows are always ignored. */ || MINI_WINDOW_P (w)) break; *************** *** 2064,2070 **** case GET_LARGEST_WINDOW: { /* nil `obj' means to ignore dedicated windows. */ /* Ignore dedicated windows and minibuffers. */ ! if (MINI_WINDOW_P (w) || (NILP (obj) && EQ (w->dedicated, Qt))) break; if (NILP (best_window)) --- 2064,2070 ---- case GET_LARGEST_WINDOW: { /* nil `obj' means to ignore dedicated windows. */ /* Ignore dedicated windows and minibuffers. */ ! if (MINI_WINDOW_P (w) || (NILP (obj) && !NILP (w->dedicated))) break; if (NILP (best_window))