From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: delete-process bug Date: Fri, 26 May 2006 01:51:52 +0200 Message-ID: References: <87k69eyddj.fsf@lrde.org> <87fyj0r41g.fsf@lrde.org> <20060524112846.GA12046@agmartin.aq.upm.es> <87bqtmjrsh.fsf_-_@lrde.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1148601275 25810 80.91.229.2 (25 May 2006 23:54:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 25 May 2006 23:54:35 +0000 (UTC) Cc: =?utf-8?Q?Micha=C3=ABl?= Cadilhac , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 26 01:54:31 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FjPet-0000JB-Kl for ged-emacs-devel@m.gmane.org; Fri, 26 May 2006 01:54:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FjPes-0003Zn-Iq for ged-emacs-devel@m.gmane.org; Thu, 25 May 2006 19:54:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FjPei-0003ZY-EH for emacs-devel@gnu.org; Thu, 25 May 2006 19:54:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FjPeh-0003ZA-HV for emacs-devel@gnu.org; Thu, 25 May 2006 19:54:16 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FjPeh-0003Z7-EJ for emacs-devel@gnu.org; Thu, 25 May 2006 19:54:15 -0400 Original-Received: from [195.41.46.237] (helo=pfepc.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FjPjT-0003FZ-3s for emacs-devel@gnu.org; Thu, 25 May 2006 19:59:11 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepc.post.tele.dk (Postfix) with SMTP id 964B58A001B; Fri, 26 May 2006 01:54:05 +0200 (CEST) Original-To: Stefan Monnier In-Reply-To: (Stefan Monnier's message of "Thu, 25 May 2006 10:55:08 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55296 Archived-At: Stefan Monnier writes: > +static Lisp_Object live_deleted_processes; What about deleted_pid_list ? > + > DEFUN ("delete-process", Fdelete_process, Sdelete_process, 1, 1, 0, > doc: /* Delete PROCESS: kill it and forget about it immediately. > PROCESS may be a process, a buffer, the name of a process or buffer, or > @@ -800,6 +807,9 @@ > else if (XINT (p->infd) >= 0) > { > Fkill_process (process, Qnil); > + live_deleted_processes = Fcons (make_number (p->pid), IIRC, using an EMACS_INT for storing pids was unsafe. Using a float is better. > + tail = Fmemq (make_number (pid), live_deleted_processes); Ditto. -- Kim F. Storm http://www.cua.dk