From: joakim@verona.se
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets
Date: Tue, 03 Feb 2015 23:38:28 +0100 [thread overview]
Message-ID: <m3egq6hb8b.fsf@exodia.verona.se> (raw)
In-Reply-To: <54CE05A0.2090701@cs.ucla.edu> (Paul Eggert's message of "Sun, 01 Feb 2015 02:53:20 -0800")
Paul Eggert <eggert@cs.ucla.edu> writes:
> joakim@verona.se wrote:
>>> Given the above, maybe you should revert the merge. Then squash all
>>> >commits in xwidget into one patch, amend it with proper ChangeLog
>>> >entries, and then do the merge.
>>> >
>> Perhaps that would be best.
>
> Yes, please do that. Here are some other things to do before committing the merge.
>
> * Reindent as per GNU standards. Start with "indent -gnu" but it
> won't do a perfect job. E.g., say "char *p" not "char* p".
>
> * Fit it into 80 columns.
>
> * Use GNU style for comments. These should typically use complete,
> imperative sentences.
>
> * Configure with "./configure --enable-gcc-warnings --with-xwidgets
> --with-x-toolkit=gtk3" and fix all the warnings.
I started fixing a bunch of the warnings, and it improves the code, so
thanks for the hint. I commited to the branch.
Is there a way to get the same warning, but not have compilation error
out though? There seems to be a bunch of gtk warnings I cant really do
anything about.
--enable-gtk-deprecation-warnings
seems to be good as well.
>
> * It's OK to assume C99 now.
>
> * Don't make functions extern unless they need to be extern.
> Compilers do a better job with static functions, typically.
>
> * Some of those function names are too long; please shorten them.
>
> * A lot of the printf statements look like they shouldn't be there.
>
> * There's some commented-out code that should be removed.
>
> * Omit pointer casts that aren't needed (when casting to and from void *).
>
> I started to look into all that and came up with the attached patch,
> relative to commit 9fe732a02afbe0b3d4a85d2bcae687900ab881f7; please
> have a look. But the result still doesn't compile due to warnings and
> I'm sure I missed a lot of things. I hope you can finish the job.
> (Also, the ChangeLog entries need to be written -- I started on that
> but it's a big job and it's something the author of the patch really
> should do.)
>
>
--
Joakim Verona
next prev parent reply other threads:[~2015-02-03 22:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150201003025.18138.95966@vcs.savannah.gnu.org>
[not found] ` <E1YHiQk-0004jf-UH@vcs.savannah.gnu.org>
2015-02-01 6:11 ` [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Dmitry Gutov
2015-02-01 8:50 ` joakim
2015-02-01 10:53 ` Paul Eggert
2015-02-01 15:46 ` joakim
2015-02-01 16:09 ` Dmitry Gutov
2015-02-01 16:17 ` joakim
2015-02-01 16:30 ` Dmitry Gutov
2015-02-01 19:48 ` joakim
2015-02-01 19:53 ` Paul Eggert
2015-02-01 19:59 ` joakim
2015-02-01 20:05 ` Dmitry Gutov
2015-02-01 20:08 ` David Engster
2015-02-01 20:18 ` Dmitry Gutov
2015-02-01 20:21 ` David Engster
2015-02-03 22:38 ` joakim [this message]
2015-02-03 23:42 ` Paul Eggert
2015-02-04 15:59 ` joakim
2015-02-04 18:57 ` joakim
2015-02-05 0:38 ` Paul Eggert
2015-02-05 15:54 ` joakim
2015-02-05 16:17 ` Paul Eggert
2015-02-09 11:50 ` joakim
2015-02-09 11:56 ` joakim
2015-02-09 19:47 ` Paul Eggert
2015-02-09 20:24 ` joakim
2015-02-09 22:20 ` Paul Eggert
2015-02-10 18:27 ` joakim
2015-02-01 15:36 ` Eli Zaretskii
2015-02-01 15:51 ` David Engster
2015-02-01 15:52 ` joakim
2015-02-01 16:04 ` David Engster
2015-02-01 16:04 ` Eli Zaretskii
2015-02-01 16:05 ` Andreas Schwab
2015-02-01 16:11 ` David Engster
2015-02-01 16:15 ` Andreas Schwab
2015-02-01 16:18 ` joakim
2015-02-01 19:29 ` David Engster
2015-02-01 19:39 ` Dmitry Gutov
2015-02-01 19:56 ` Eli Zaretskii
2015-02-01 20:41 ` Dmitry Gutov
2015-02-02 3:30 ` Eli Zaretskii
2015-02-02 8:03 ` David Engster
2015-02-02 10:53 ` Ulrich Mueller
2015-02-02 16:30 ` Eli Zaretskii
2015-02-02 23:19 ` Stefan Monnier
2015-02-02 1:35 ` Stephen J. Turnbull
2015-02-02 1:57 ` Dmitry Gutov
2015-02-02 2:12 ` Stephen J. Turnbull
2015-02-02 2:21 ` Dmitry Gutov
2015-02-02 3:45 ` Stephen J. Turnbull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3egq6hb8b.fsf@exodia.verona.se \
--to=joakim@verona.se \
--cc=dgutov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.