From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Date: Wed, 04 Feb 2015 19:57:25 +0100 Message-ID: References: <20150201003025.18138.95966@vcs.savannah.gnu.org> <54CDC38C.9080701@yandex.ru> <54CE05A0.2090701@cs.ucla.edu> <54D15CF5.3020809@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1423076283 15517 80.91.229.3 (4 Feb 2015 18:58:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2015 18:58:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 04 19:58:02 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJ59F-00033N-Na for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2015 19:58:01 +0100 Original-Received: from localhost ([::1]:38153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ59E-0003M6-T6 for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2015 13:58:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ59B-0003M1-Jt for emacs-devel@gnu.org; Wed, 04 Feb 2015 13:57:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ597-0007px-6U for emacs-devel@gnu.org; Wed, 04 Feb 2015 13:57:57 -0500 Original-Received: from mx6.bahnhof.se ([213.80.101.16]:56154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ596-0007pm-WD for emacs-devel@gnu.org; Wed, 04 Feb 2015 13:57:53 -0500 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx6-reinject (Postfix) with ESMTP id 5AC34440F3; Wed, 4 Feb 2015 19:57:51 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF2) Original-Received: from mf2.bahnhof.se ([127.0.0.1]) by localhost (mf2.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dppnK7LdQdfC; Wed, 4 Feb 2015 19:57:45 +0100 (CET) Original-Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf2.bahnhof.se (Postfix) with ESMTP id 6FB2294013E; Wed, 4 Feb 2015 19:57:45 +0100 (CET) Original-Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id 2E79952B81A; Wed, 4 Feb 2015 18:57:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Original-Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3EtFeK4bflQA; Wed, 4 Feb 2015 19:57:25 +0100 (CET) Original-Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id D574152B819; Wed, 4 Feb 2015 19:57:25 +0100 (CET) In-Reply-To: (joakim@verona.se's message of "Wed, 04 Feb 2015 16:59:18 +0100") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 213.80.101.16 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182384 Archived-At: joakim@verona.se writes: > Paul Eggert writes: > >> joakim@verona.se wrote: >>> There seems to be a bunch of gtk warnings I cant really do anything abo= ut. >> >> You should be able to fix them all. The attached patch did that for >> me, on Ubuntu 14.10 anyway. This patch uses the usual GNU Emacs style >> in the code I fixed; similar fixes are needed for the rest of the >> xwidget code, but one thing at a time.) > > Cool, with your advice I was able to fix all the warnings! > I pushed such a patch (similar to yours) to the repo now. > > Next I will run gnu indent. Running indent didn't work out too well. I get stuff like this: xwidget.c: In function =E2=80=98Fmake_xwidget=E2=80=99: xwidget.c:221:3: error: =E2=80=98Vxwidget_list=E2=80=99 undeclared (first u= se in this function) Vxwidget_list =3D Fcons (val, Vxwidget_list); ^ I'm guessing gnu indent breaks some Emacs build macrology. Any hints? > >> >>> --enable-gtk-deprecation-warnings >>> >>> seems to be good as well. >> >> That's disabled by default due to its false alarms. It is helpful to >> enable it occasionally, and you can still build despite the warnings >> by using 'make WERROR_CFLAGS=3D'. I don't recommend this for ordinary >> development, though. >> >> --=20 Joakim Verona