From: joakim@verona.se
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets
Date: Wed, 04 Feb 2015 19:57:25 +0100 [thread overview]
Message-ID: <m3egq5qzca.fsf@exodia.verona.se> (raw)
In-Reply-To: <m3r3u5r7l5.fsf@exodia.verona.se> (joakim@verona.se's message of "Wed, 04 Feb 2015 16:59:18 +0100")
joakim@verona.se writes:
> Paul Eggert <eggert@cs.ucla.edu> writes:
>
>> joakim@verona.se wrote:
>>> There seems to be a bunch of gtk warnings I cant really do anything about.
>>
>> You should be able to fix them all. The attached patch did that for
>> me, on Ubuntu 14.10 anyway. This patch uses the usual GNU Emacs style
>> in the code I fixed; similar fixes are needed for the rest of the
>> xwidget code, but one thing at a time.)
>
> Cool, with your advice I was able to fix all the warnings!
> I pushed such a patch (similar to yours) to the repo now.
>
> Next I will run gnu indent.
Running indent didn't work out too well.
I get stuff like this:
xwidget.c: In function ‘Fmake_xwidget’:
xwidget.c:221:3: error: ‘Vxwidget_list’ undeclared (first use in this function)
Vxwidget_list = Fcons (val, Vxwidget_list);
^
I'm guessing gnu indent breaks some Emacs build macrology.
Any hints?
>
>>
>>> --enable-gtk-deprecation-warnings
>>>
>>> seems to be good as well.
>>
>> That's disabled by default due to its false alarms. It is helpful to
>> enable it occasionally, and you can still build despite the warnings
>> by using 'make WERROR_CFLAGS='. I don't recommend this for ordinary
>> development, though.
>>
>>
--
Joakim Verona
next prev parent reply other threads:[~2015-02-04 18:57 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150201003025.18138.95966@vcs.savannah.gnu.org>
[not found] ` <E1YHiQk-0004jf-UH@vcs.savannah.gnu.org>
2015-02-01 6:11 ` [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Dmitry Gutov
2015-02-01 8:50 ` joakim
2015-02-01 10:53 ` Paul Eggert
2015-02-01 15:46 ` joakim
2015-02-01 16:09 ` Dmitry Gutov
2015-02-01 16:17 ` joakim
2015-02-01 16:30 ` Dmitry Gutov
2015-02-01 19:48 ` joakim
2015-02-01 19:53 ` Paul Eggert
2015-02-01 19:59 ` joakim
2015-02-01 20:05 ` Dmitry Gutov
2015-02-01 20:08 ` David Engster
2015-02-01 20:18 ` Dmitry Gutov
2015-02-01 20:21 ` David Engster
2015-02-03 22:38 ` joakim
2015-02-03 23:42 ` Paul Eggert
2015-02-04 15:59 ` joakim
2015-02-04 18:57 ` joakim [this message]
2015-02-05 0:38 ` Paul Eggert
2015-02-05 15:54 ` joakim
2015-02-05 16:17 ` Paul Eggert
2015-02-09 11:50 ` joakim
2015-02-09 11:56 ` joakim
2015-02-09 19:47 ` Paul Eggert
2015-02-09 20:24 ` joakim
2015-02-09 22:20 ` Paul Eggert
2015-02-10 18:27 ` joakim
2015-02-01 15:36 ` Eli Zaretskii
2015-02-01 15:51 ` David Engster
2015-02-01 15:52 ` joakim
2015-02-01 16:04 ` David Engster
2015-02-01 16:04 ` Eli Zaretskii
2015-02-01 16:05 ` Andreas Schwab
2015-02-01 16:11 ` David Engster
2015-02-01 16:15 ` Andreas Schwab
2015-02-01 16:18 ` joakim
2015-02-01 19:29 ` David Engster
2015-02-01 19:39 ` Dmitry Gutov
2015-02-01 19:56 ` Eli Zaretskii
2015-02-01 20:41 ` Dmitry Gutov
2015-02-02 3:30 ` Eli Zaretskii
2015-02-02 8:03 ` David Engster
2015-02-02 10:53 ` Ulrich Mueller
2015-02-02 16:30 ` Eli Zaretskii
2015-02-02 23:19 ` Stefan Monnier
2015-02-02 1:35 ` Stephen J. Turnbull
2015-02-02 1:57 ` Dmitry Gutov
2015-02-02 2:12 ` Stephen J. Turnbull
2015-02-02 2:21 ` Dmitry Gutov
2015-02-02 3:45 ` Stephen J. Turnbull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3egq5qzca.fsf@exodia.verona.se \
--to=joakim@verona.se \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.