From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33665: 27.0.50; Variables not set up in Gnus when hooks are run Date: Fri, 07 Dec 2018 19:04:07 +0100 Message-ID: References: <875zw5xn9a.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1544205795 9405 195.159.176.226 (7 Dec 2018 18:03:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 7 Dec 2018 18:03:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33665@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 07 19:03:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVKT0-0002JM-Vt for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Dec 2018 19:03:11 +0100 Original-Received: from localhost ([::1]:47624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVKV7-0005iJ-2x for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Dec 2018 13:05:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVKUy-0005iB-98 for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 13:05:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVKUs-0005JB-6L for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 13:05:12 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33032) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gVKUo-0005Ga-3L for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 13:05:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gVKUn-0003Kl-Ly for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 13:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Dec 2018 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33665 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33665-submit@debbugs.gnu.org id=B33665.154420586612772 (code B ref 33665); Fri, 07 Dec 2018 18:05:01 +0000 Original-Received: (at 33665) by debbugs.gnu.org; 7 Dec 2018 18:04:26 +0000 Original-Received: from localhost ([127.0.0.1]:37290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVKUB-0003Jt-7i for submit@debbugs.gnu.org; Fri, 07 Dec 2018 13:04:26 -0500 Original-Received: from ryder.getmail.no ([84.210.184.14]:41696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVKU6-0003Jb-37 for 33665@debbugs.gnu.org; Fri, 07 Dec 2018 13:04:21 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by ryder.getmail.no (Postfix) with ESMTP id 487ED62E86; Fri, 7 Dec 2018 19:04:09 +0100 (CET) Original-Received: from ryder.getmail.no ([127.0.0.1]) by localhost (ryder.get.c.bitbit.net [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id drJNVKqXKJPZ; Fri, 7 Dec 2018 19:04:08 +0100 (CET) Original-Received: from localhost (localhost [127.0.0.1]) by ryder.getmail.no (Postfix) with ESMTP id 7560A62E83; Fri, 7 Dec 2018 19:04:08 +0100 (CET) X-Virus-Scanned: amavisd-new at ryder.getmail.no Original-Received: from ryder.getmail.no ([127.0.0.1]) by localhost (ryder.get.c.bitbit.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id O15RAyfvPuIb; Fri, 7 Dec 2018 19:04:08 +0100 (CET) Original-Received: from stories (cm-84.212.221.165.getinternet.no [84.212.221.165]) by ryder.getmail.no (Postfix) with ESMTPSA id 2548062E7F; Fri, 7 Dec 2018 19:04:08 +0100 (CET) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEX+/Oz712rbWBLypDCz DwP87qVQxRiGAAACW0lEQVQ4jV2UbY7jIAyGqUb8j4M4QAzzf7GbAyzlAGEj7n+VfU3S2ZlFaqXy 4M/XrlsbTmVWItUiSTPHlXl3GdepDHcdP4YyV06H49YSHe7fIcl4ejiVVuK3e+cl18+Bp2vT5du1 8yrb4gYe1P9A0GKuT2mpHD989d1+h5CTFveD7DOJnmuhK/zo8RvwuSYihOlBeF75iclJ49gX11Vz jT9Arps7vKCixpt5nCC6k1s6RmBGd5iXL+C7+TrlBjAZZK2jAN9ccM/WZkWXRrDCUCj6qQJsArDs BmDxAaCMD4DZcBokZvE4VV6cEjE6AMZcSHYE8dTP2jRByYp8KwmvT7TXnRsA7+kJNwBty/mZVyTc t0CcPgEsRm2/n+1Zkz9M5T3ztpkFPLUXXrySKWgill2k3WfFyGz3cITDdcnXfUXyKR5f4CF8W9Sa +a1ogPhB89tZm+BA48NyRhP/bZMui7OgHyX69b7m9wB+WLOQyfGcr1XKJb17RKiqKf96jOF7pFCg lDdwQL1U9BqEw3eKY1ghvUOl7U69A5RxzVEPnPk9pZhZAgg0x1vyBqcrGufVJhRALQbES/iNsvrJ 8FBGnyCUkF8wXK5p8l1HVzG3oz+rhZ2r5kdIGgA80hlrjYNmTQU7ihoBzqSENUWJNCzoHCYtqxMt vVCy2uccJeH5yjEA9RvYHWTCTi8OOzGOPwZKmJNne+ZlccEeBKVAOADXhsgnqhgUT8W2dSPl3vXq zMOODS40Te5ehuTMua2CsMWxfOYKbG6+RbP4DRT/OCfEKSeFYNLO9GEQ5nf8C57Oo2VU/QPdAAAA AElFTkSuQmCC In-Reply-To: <875zw5xn9a.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 07 Dec 2018 09:25:21 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153187 Archived-At: Eric Abrahamsen writes: > Lars Ingebrigtsen writes: > >> It looks like gnus-newsgroup-name (and friends?) are no longer set when >> the summary mode hooks are run, so hooks that rely on that are now >> broken. > > Yes, since `gnus-summary-mode' is now a real mode, it clears local > variables before running the hook. The right place for that sort of hook > is now `gnus-summary-prepared-hook'. I tried to change all the relevant > hooks I could within the codebase, but I guess gnus-mdrtn.el isn't > publicly available? I can change the Moderation section of the manual to > update the installation instructions. No, you can't break third-party software that way. You have to set the variables the hooks expect to exist before calling the hook. >> It also looks like summary mode line highlights no longer works. I think that was a false alarm. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no