From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes Date: Tue, 25 Jun 2019 16:42:27 +0200 Message-ID: References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="102399"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 22457@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 16:53:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfmp6-000QLQ-Ep for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 16:53:28 +0200 Original-Received: from localhost ([::1]:32804 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfmp2-0000WR-DT for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 10:53:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49201) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfmf2-0003Fk-I9 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 10:43:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfmf0-0003iP-Po for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 10:43:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47867) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfmf0-0003iC-LK for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 10:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfmf0-000375-H6 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 10:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22457 X-GNU-PR-Package: emacs Original-Received: via spool by 22457-submit@debbugs.gnu.org id=B22457.156147375511928 (code B ref 22457); Tue, 25 Jun 2019 14:43:02 +0000 Original-Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 14:42:35 +0000 Original-Received: from localhost ([127.0.0.1]:33178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfmeZ-00036J-3y for submit@debbugs.gnu.org; Tue, 25 Jun 2019 10:42:35 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:50824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfmeX-000369-GX for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 10:42:33 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfmeR-00013Q-CZ; Tue, 25 Jun 2019 16:42:29 +0200 In-Reply-To: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> (Drew Adams's message of "Sun, 24 Jan 2016 10:05:44 -0800 (PST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161375 Archived-At: Drew Adams writes: > `dired-mark-if' marks, unmarks, or flags Dired lines that satisfy its > PREDICATE argument. > > But it should do nothing if a given line is already so marked, unmarked, > or flagged. More importantly, it should not count that line as having > been marked, unmarked, or flagged. The message that echoes the count of > changes should not take such non-changes into account. That sounds like a sensible change, and a cursory look at the code seems to say that nothing uses the return value, anyway. (So it shouldn't break anything.) (But my look was very cursory; this should be confirmed by looking at the code closer.) > Here is a fixed version of the macro. The diff is trivial. No diff was included, which, as usual, is a shame, because the macro has changed slightly in the meantime. > (cond ((eq dired-marker-char ?\040) "Unmarking") ?\040 isn't the recommended way of saying "space". > ((eq dired-del-marker dired-marker-char) "Flagging") > (t "Marking")) Your lines are also too wide; they should be less than 80 characters wide. Could you re-spin your change and submit a patch? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no