From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: x86_64 problems/fix (was: alloc.c problem when GC_MARK_STACK is GC_USE_GCPROS_AS_BEFORE) Date: 12 Jul 2004 11:33:14 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1089624796 23458 80.91.224.253 (12 Jul 2004 09:33:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 12 Jul 2004 09:33:16 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Jul 12 11:33:04 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BjxBI-0001Yk-00 for ; Mon, 12 Jul 2004 11:33:04 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BjxBH-0006ZI-00 for ; Mon, 12 Jul 2004 11:33:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BjxDb-0004pq-AL for emacs-devel@quimby.gnus.org; Mon, 12 Jul 2004 05:35:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BjxDM-0004pe-NA for emacs-devel@gnu.org; Mon, 12 Jul 2004 05:35:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BjxDK-0004p0-Hv for emacs-devel@gnu.org; Mon, 12 Jul 2004 05:35:12 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BjxDK-0004oo-A7 for emacs-devel@gnu.org; Mon, 12 Jul 2004 05:35:10 -0400 Original-Received: from [212.88.64.25] (helo=mail-relay.sonofon.dk) by monty-python.gnu.org with smtp (Exim 4.34) id 1BjxAx-0005uG-5W for emacs-devel@gnu.org; Mon, 12 Jul 2004 05:32:43 -0400 Original-Received: (qmail 49202 invoked from network); 12 Jul 2004 09:32:41 -0000 Original-Received: from unknown (HELO kfs-l.imdomain.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 12 Jul 2004 09:32:41 -0000 Original-To: Barry Fishman In-Reply-To: Original-Lines: 76 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25604 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25604 Barry Fishman writes: > I was unable to make any change to alloc.c that would fix the GC_MARK_STACK > problem without later crashes in the build while compiling the lisp > files. Does the following patch work (if you undo the patch you suggested below)? *** alloc.c 23 Jun 2004 10:30:52 +0200 1.346 --- alloc.c 12 Jul 2004 11:29:19 +0200 *************** *** 5033,5038 **** --- 5033,5039 ---- break; case Lisp_Misc_Save_Value: + #if GC_MARK_STACK { register struct Lisp_Save_Value *ptr = XSAVE_VALUE (obj); /* If DOGC is set, POINTER is the address of a memory *************** *** 5045,5050 **** --- 5046,5052 ---- mark_maybe_object (*p); } } + #endif break; case Lisp_Misc_Overlay: > > However, I suspect the attached change to src/s/gnu-linux.h is > approprate. This produces a working emacs (for me) on a amd64 > gnu-linux system (SuSE 9.1), although it sidesteps the problem in > alloc.c. This is a good change -- have you been using that for some time now without problems? If so, I will commit your patch. > > Index: gnu-linux.h > =================================================================== > RCS file: /cvsroot/emacs/emacs/src/s/gnu-linux.h,v > retrieving revision 1.89 > diff -c -r1.89 gnu-linux.h > *** gnu-linux.h 1 Sep 2003 15:45:58 -0000 1.89 > --- gnu-linux.h 6 Jul 2004 23:49:36 -0000 > *************** > *** 355,361 **** > > #if defined __i386__ || defined __sparc__ || defined __mc68000__ \ > || defined __alpha__ || defined __mips__ || defined __s390__ \ > ! || defined __arm__ || defined __powerpc__ > #define GC_SETJMP_WORKS 1 > #define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS > #ifdef __mc68000__ > --- 355,361 ---- > > #if defined __i386__ || defined __sparc__ || defined __mc68000__ \ > || defined __alpha__ || defined __mips__ || defined __s390__ \ > ! || defined __arm__ || defined __powerpc__ || defined __amd64__ > #define GC_SETJMP_WORKS 1 > #define GC_MARK_STACK GC_MAKE_GCPROS_NOOPS > #ifdef __mc68000__ > > -- > Barry Fishman > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-devel -- Kim F. Storm http://www.cua.dk