From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#19678: [PATCH] EUDC does not support BBDB 3.x Date: Mon, 26 Jan 2015 17:21:22 -0500 Message-ID: References: <87mw57hhrd.fsf@sergiodj.net> <87lhkpjrg3.fsf@sergiodj.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1422310939 1504 80.91.229.3 (26 Jan 2015 22:22:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 26 Jan 2015 22:22:19 +0000 (UTC) Cc: 19678@debbugs.gnu.org To: Sergio Durigan Junior Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 26 23:22:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YFs2v-0002Xd-86 for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Jan 2015 23:22:13 +0100 Original-Received: from localhost ([::1]:44355 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFs2u-0000Oy-94 for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Jan 2015 17:22:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFs2p-0000OO-Dp for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 17:22:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFs2k-0006wn-Vq for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 17:22:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFs2k-0006wj-TK for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 17:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YFs2k-0000Pw-Fl for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 17:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Jan 2015 22:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19678 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19678-submit@debbugs.gnu.org id=B19678.14223108931565 (code B ref 19678); Mon, 26 Jan 2015 22:22:02 +0000 Original-Received: (at 19678) by debbugs.gnu.org; 26 Jan 2015 22:21:33 +0000 Original-Received: from localhost ([127.0.0.1]:57361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFs2H-0000PA-5P for submit@debbugs.gnu.org; Mon, 26 Jan 2015 17:21:33 -0500 Original-Received: from mail-ig0-f177.google.com ([209.85.213.177]:36196) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFs2E-0000Os-IN for 19678@debbugs.gnu.org; Mon, 26 Jan 2015 17:21:31 -0500 Original-Received: by mail-ig0-f177.google.com with SMTP id z20so1290056igj.4 for <19678@debbugs.gnu.org>; Mon, 26 Jan 2015 14:21:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=sCeDBeStt/Ztq/W0d/KSJoeflkIbImAOmFSFODJ7Rgw=; b=Vn58YqYOytOi0QQsoIrm/DFHZmx87DJLVac6nRDslEQAe++5Zp7JIozSIh0gUJgEO2 OCabO67M2PbgWeACYJ9q7cx1PflxAzgyCpZXqjkG23QjmUOhKEVgGfAeiUZblBT31Fye qsD20IJ9r+Urq5/GTMeJMdb7RTIENOjnI21cvIm2QHuiqthVSw4T2UafuC+INBwISmGP 8SgD1XyaqyK0tuDzUhK18VPDpnskkPRaFHWI5W6XI0m7QLiYX1u40uCCReYQ/nD/x6Kb WTEtbRXluYDUZkwWpTVambPJ+fNGI6DipPa5wr3VmxHKQ2aSIVya5XLHKtNRiYovTj3V MHMg== X-Gm-Message-State: ALoCoQnXG32zFRV9NDSXN2YAtrAfnj1dM66X0kJ9Hi3fXvIYiO13qtzG1RvahTfysWFz8s83sB1x X-Received: by 10.107.5.85 with SMTP id 82mr21516892iof.41.1422310884817; Mon, 26 Jan 2015 14:21:24 -0800 (PST) Original-Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by mx.google.com with ESMTPSA id nv8sm6505828igb.6.2015.01.26.14.21.23 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 26 Jan 2015 14:21:24 -0800 (PST) In-Reply-To: <87lhkpjrg3.fsf@sergiodj.net> (Sergio Durigan Junior's message of "Mon, 26 Jan 2015 14:02:36 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98770 Archived-At: Sergio Durigan Junior writes: > On Sunday, January 25 2015, Thomas Fitzsimmons wrote: > >> Can you see if the attached patch works for you? It works for me, >> introduces minimal changes and allows for upgrading BBDB 2 to BBDB 3 >> without restarting Emacs. The defvar change in your patch concerns me >> because it will miss if the BBDB version changes after the variable is >> first assigned. > > Almost there... The patch doesn't work as-is because > 'eudc-bbdb-current-return-attributes' is set to '(firstname lastname > mail) for me when eudc-bbdb-format-record-as-result is called. It means > that, in the while loop, it will try to call eq/memq against 'mail, and > it fails. Hmm, I thought those get converted; in any case, I wasn't seeing that problem. Do you have any customizations of the relevant variables? Do you have my latest EUDC/LDAP changes from master tip? Can we step back a bit and make sure we're doing the same tests? BBDB 2.x is tricky because it is provided by the distro, in my case Fedora. Let's focus on testing BBDB 3.x so that I can replicate the exact same issue that you're seeing. Can you revert our patch, then: 1) Checkout and build Emacs revision 03a20dc9519616359bfa1b77fd4b31e1963c8bd4 from git://git.savannah.gnu.org/emacs.git This revision has a bunch of my EUDC/LDAP updates in it. 2) Download http://download.savannah.gnu.org/releases/bbdb/bbdb-3.1.2.tar.gz 3) Untar and build the ELPA package: export EMACS=/src/emacs ./configure && make elpa unset EMACS 4) In the emacs src directory: mkdir test-home 5) HOME=`pwd`/test-home ./emacs -Q 6) M-x package-install-file bbdb-3.1.2.tar (the one built in step 3) 7) M-x bbdb-create Name: Test User Network Address: test@gnu.org 8) C-x s to save .bbdb 9) M-: (eval-after-load "message" '(define-key message-mode-map (kbd "TAB") 'eudc-expand-inline)) 10) M-: (setq debug-on-error 't) 11) C-x m 12) Tes[TAB] (no server, bbdb protocol) Without my patch, I get: Debugger entered--Lisp error: (void-function bbdb-record-net) (bbdb-record-net record) eval((bbdb-record-net record)) eudc-bbdb-format-record-as-result(["Test" "User" nil nil nil nil nil ("test@gnu.org") ((creation-date . "2015-01-26 21:56:26 +0000") (timestamp . "2015-01-26 21:56:26 +0000")) ["Test User" "User, Test" nil ("test@gnu.org") nil #]]) mapcar(eudc-bbdb-format-record-as-result (["Test" "User" nil nil nil nil nil ("test@gnu.org") ((creation-date . "2015-01-26 21:56:26 +0000") (timestamp . "2015-01-26 21:56:26 +0000")) ["Test User" "User, Test" nil ("test@gnu.org") nil #]])) eudc-bbdb-query-internal(((firstname . "Tes")) (firstname lastname net)) eudc-query(((firstname . "Tes")) (firstname lastname net)) eudc-expand-inline() funcall-interactively(eudc-expand-inline) call-interactively(eudc-expand-inline nil nil) command-execute(eudc-expand-inline) With my patch (0001-EUDC-Support-BBDB-3.patch), it works. eudc-query gets called with 'net, not 'mail. If that works for you, can you try to replicate the other error you're seeing when my patch is applied, in this same minimal environment, and paste the testing steps and the backtrace you get? Thanks, Thomas