From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 3/5] Permit systemd-allocated socket file-descriptors to be used. Date: Sun, 27 Mar 2016 14:08:56 +0200 Message-ID: References: <1459027002-13215-1-git-send-email-matthew@mattleach.net> <1459027002-13215-4-git-send-email-matthew@mattleach.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1459080575 12669 80.91.229.3 (27 Mar 2016 12:09:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Mar 2016 12:09:35 +0000 (UTC) Cc: emacs-devel To: Matthew Leach Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 27 14:09:19 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ak9VM-0001yD-Pt for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2016 14:09:17 +0200 Original-Received: from localhost ([::1]:35763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ak9VL-0005RL-On for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2016 08:09:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ak9VH-0005Qr-5I for emacs-devel@gnu.org; Sun, 27 Mar 2016 08:09:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ak9VC-0004Cb-6P for emacs-devel@gnu.org; Sun, 27 Mar 2016 08:09:11 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:45774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ak9VB-0004Bt-WA for emacs-devel@gnu.org; Sun, 27 Mar 2016 08:09:06 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.84_2) (envelope-from ) id 1ak9V2-0000Ui-JF; Sun, 27 Mar 2016 14:08:58 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUsBgoGAQLw0YrDXCsu CgsZAwZCERCCIxoS5R0JAAACVklEQVQ4jW2US2/bMBCEGTRurhVgyneqaO/a1Lw6qCRfI0BrX1OY Iq9B6HD/fofyI3JaAgLs/TSzOyRtVRTF81j8uxQevfgfWD4ti/SnLFM5L9/fqVUyZKraVIa+X+va j2plruvHDLwo7Vrm378GblvXf4BG9ck7533As7lOpx2rwQffheRDStpfJb1WrP2uLRu3G7ti+XSu M8adXtL9tTB9bU8BZxX/1Td4qb+Ccz0I1kt/2ZLbusj4GZzrkvpbsJMLGG/AMghVNWXS3DQPUlNN xkry/m4Gyki1ofqt+gweIlXZChK3mVlpIcqS3OXIs+arSJYMTowqmxYzEGIWGAMvklmP7BQzqKq6 Inm9glIqWE0SNMrZz2APgJVPHrfCTkCftq9CujOA16JXBWNolpOiPl0XNGEoel18E4GBnCQmf2zR gwm9Y03WxzOA2gKsCL1jXVnXfZhlsLd6KwIwcrQXTQZbm880GoAHobPXpFh/sRKi+Sl+M4h5Q3qy r5NVRFZ4IdhLR7GSdUo8AcqAsIFWNiGZR8ucQUAymwLlKaUdfD167nPALmXQYXOxFy13XTtwwYr7 AcFsaqTOe7GASzudID50B4AWXsi1aVCAoFeaO9QoNRgYXsk3+IUNwSl+9qNcgEF71/pxG0UNXePR 3EJWZ0k8urDeSwYukJDl3XTmltbuYMvHTukOGxVwl3ifu/t4bHeCyVSx3Cc3yHHkgepKGnlnFm7e kbzErd81iflAUTqPeMzbI4DOeYajLLZ0IHffDph3G6d/n3x/krzucLVG5AbYy1916/bpmPelkAAA AABJRU5ErkJggg== In-Reply-To: <1459027002-13215-4-git-send-email-matthew@mattleach.net> (Matthew Leach's message of "Sat, 26 Mar 2016 21:16:40 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202282 Archived-At: Having systemd support in Emacs is probably nice, I think, but one comment on this part of the patch series: Matthew Leach writes: > * src/process.c (connect_network_socket): Allow a systemd-allocated > file-descriptor to be passed, and use it, avoiding the call to > socket() and bind(). [...] > +connect_network_socket (Lisp_Object proc, Lisp_Object ip_addresses, > + Lisp_Object systemd_fd) [...] > - s = socket (family, p->socktype | SOCK_CLOEXEC, p->ai_protocol); > + if (use_systemd_fd) > + s = XINT (systemd_fd); > + else > + s = socket (family, p->socktype | SOCK_CLOEXEC, p->ai_protocol); > + [...] > +:systemd-fd INT -- use this file-descriptor, passed in through systemd, > + and don't call socket() and bind(). There isn't really anything systemd-specific about any of this code (as far as I can see): It's about calling `make-network-socket' on a file descriptor that's already been opened. So I'd just rename this parameter to :allocated-file-descriptor or something and adjust the names of the other variables used. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no