From: Lars Ingebrigtsen <larsi@gnus.org>
To: Mark Oteiza <mvoteiza@udel.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] eww-open-in-new-buffer
Date: Wed, 02 Nov 2016 20:22:47 +0100 [thread overview]
Message-ID: <m3d1idit4o.fsf@gnus.org> (raw)
In-Reply-To: <87shramye1.fsf@udel.edu> (Mark Oteiza's message of "Tue, 01 Nov 2016 22:03:18 -0400")
Mark Oteiza <mvoteiza@udel.edu> writes:
> I wanted something akin to "open in new tab" for eww, so I wrote the
> following.
>
> M-RET seemed a good binding. One thing that bugs me about this is that
> eww-current-url in eww-suggest-uris didn't quite fit: as the new
> function is, it doesn't make sense if url is (eww-current-url).
>
> So, I made changes to eww-suggest-uris. Alternatively,
> eww-open-in-new-buffer could check if url is equal to eww-current-url
> and just clone instead of invoking eww. That might be better.
Looks good to me, I think. It should probably have a NEWS entry and an
eww manual entry, though.
> (defcustom eww-suggest-uris
> '(eww-links-at-point
> - url-get-url-at-point
> - eww-current-url)
> + url-get-url-at-point)
And this should have a :version "26.1".
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-11-02 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 2:03 [PATCH] eww-open-in-new-buffer Mark Oteiza
2016-11-02 19:22 ` Lars Ingebrigtsen [this message]
2016-11-02 20:52 ` Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d1idit4o.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=mvoteiza@udel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.