From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Bug in incremental undrawing of mouseover highlighting Date: Sun, 26 Nov 2006 20:05:03 +0100 Message-ID: References: <17760.56196.739515.442009@rgrjr.dyndns.org> <87zmaludmg.fsf@cyd.mit.edu> <87hcwokvkk.fsf@furball.mit.edu> <87y7pzo5yx.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1164567982 16791 80.91.229.2 (26 Nov 2006 19:06:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 26 Nov 2006 19:06:22 +0000 (UTC) Cc: Chong Yidong , rogers-emacs@rgrjr.dyndns.org, mituharu@math.s.chiba-u.ac.jp, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 26 20:06:18 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GoPKL-00078e-6b for ged-emacs-devel@m.gmane.org; Sun, 26 Nov 2006 20:06:11 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GoPKK-0007lj-Id for ged-emacs-devel@m.gmane.org; Sun, 26 Nov 2006 14:06:08 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GoPK1-0007kE-HM for emacs-devel@gnu.org; Sun, 26 Nov 2006 14:05:49 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GoPK0-0007k2-Af for emacs-devel@gnu.org; Sun, 26 Nov 2006 14:05:48 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GoPK0-0007jz-3z for emacs-devel@gnu.org; Sun, 26 Nov 2006 14:05:48 -0500 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GoPJy-0006le-1h; Sun, 26 Nov 2006 14:05:46 -0500 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx19.adsl-dhcp.tele.dk [80.62.38.68]) by pfepb.post.tele.dk (Postfix) with SMTP id 6929AA5009C; Sun, 26 Nov 2006 20:05:16 +0100 (CET) Original-To: Eli Zaretskii In-Reply-To: (Eli Zaretskii's message of "Sat\, 25 Nov 2006 23\:10\:12 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.91 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62818 Archived-At: Eli Zaretskii writes: > As to the concerns expressed by Yamamoto Mitsuharu, I would also > suggest that a redisplay expert looks into them. Chong's patch may not be the cleanest approach, but I think it is ok. However, it may be better to move the setup of dpyinfo into the BLOCK_INPUT region, like this: *** window.c 26 Nov 2006 12:21:36 +0100 1.566 --- window.c 26 Nov 2006 20:02:48 +0100 *************** *** 3267,3274 **** int count = SPECPDL_INDEX (); #ifdef HAVE_WINDOW_SYSTEM struct frame *f = XFRAME (w->frame); ! Display_Info *dpyinfo = (f && FRAME_X_OUTPUT (f)) ? ! FRAME_X_DISPLAY_INFO (f) : NULL; #endif w->buffer = buffer; --- 3267,3273 ---- int count = SPECPDL_INDEX (); #ifdef HAVE_WINDOW_SYSTEM struct frame *f = XFRAME (w->frame); ! Display_Info *dpyinfo; #endif w->buffer = buffer; *************** *** 3352,3358 **** #ifdef HAVE_WINDOW_SYSTEM BLOCK_INPUT; ! if (dpyinfo && EQ (window, dpyinfo->mouse_face_window)) clear_mouse_face (dpyinfo); UNBLOCK_INPUT; #endif --- 3351,3359 ---- #ifdef HAVE_WINDOW_SYSTEM BLOCK_INPUT; ! if (f && FRAME_X_OUTPUT (f) ! && (dpyinfo = FRAME_X_DISPLAY_INFO (f)) ! && EQ (window, dpyinfo->mouse_face_window)) clear_mouse_face (dpyinfo); UNBLOCK_INPUT; #endif -- Kim F. Storm http://www.cua.dk