From: storm@cua.dk (Kim F. Storm)
Cc: Chong Yidong <cyd@stupidchicken.com>,
rogers-emacs@rgrjr.dyndns.org, mituharu@math.s.chiba-u.ac.jp,
emacs-devel@gnu.org
Subject: Re: Bug in incremental undrawing of mouseover highlighting
Date: Sun, 26 Nov 2006 20:05:03 +0100 [thread overview]
Message-ID: <m3bqmum3kw.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <u4psn5j2j.fsf@gnu.org> (Eli Zaretskii's message of "Sat\, 25 Nov 2006 23\:10\:12 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> As to the concerns expressed by Yamamoto Mitsuharu, I would also
> suggest that a redisplay expert looks into them.
Chong's patch may not be the cleanest approach, but I think it is ok.
However, it may be better to move the setup of dpyinfo into the
BLOCK_INPUT region, like this:
*** window.c 26 Nov 2006 12:21:36 +0100 1.566
--- window.c 26 Nov 2006 20:02:48 +0100
***************
*** 3267,3274 ****
int count = SPECPDL_INDEX ();
#ifdef HAVE_WINDOW_SYSTEM
struct frame *f = XFRAME (w->frame);
! Display_Info *dpyinfo = (f && FRAME_X_OUTPUT (f)) ?
! FRAME_X_DISPLAY_INFO (f) : NULL;
#endif
w->buffer = buffer;
--- 3267,3273 ----
int count = SPECPDL_INDEX ();
#ifdef HAVE_WINDOW_SYSTEM
struct frame *f = XFRAME (w->frame);
! Display_Info *dpyinfo;
#endif
w->buffer = buffer;
***************
*** 3352,3358 ****
#ifdef HAVE_WINDOW_SYSTEM
BLOCK_INPUT;
! if (dpyinfo && EQ (window, dpyinfo->mouse_face_window))
clear_mouse_face (dpyinfo);
UNBLOCK_INPUT;
#endif
--- 3351,3359 ----
#ifdef HAVE_WINDOW_SYSTEM
BLOCK_INPUT;
! if (f && FRAME_X_OUTPUT (f)
! && (dpyinfo = FRAME_X_DISPLAY_INFO (f))
! && EQ (window, dpyinfo->mouse_face_window))
clear_mouse_face (dpyinfo);
UNBLOCK_INPUT;
#endif
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2006-11-26 19:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-19 22:32 Bug in incremental undrawing of mouseover highlighting Bob Rogers
2006-11-19 22:50 ` David Kastrup
2006-11-19 23:45 ` Bob Rogers
2006-12-13 14:45 ` Stephen Berman
2006-12-13 16:04 ` Chong Yidong
2006-12-14 9:22 ` Stephen Berman
2006-12-16 12:31 ` Stephen Berman
2006-11-20 4:20 ` Eli Zaretskii
2006-11-20 19:22 ` Chong Yidong
2006-11-20 20:24 ` misleading install instruction in emacs/mac/INSTALL Gilbert Harman
2006-11-21 7:47 ` Richard Stallman
2006-11-22 8:23 ` YAMAMOTO Mitsuharu
2006-11-22 17:07 ` Gilbert Harman
2006-11-20 20:36 ` Bug in incremental undrawing of mouseover highlighting Eli Zaretskii
2006-11-22 4:06 ` Bob Rogers
2006-11-22 18:35 ` Eli Zaretskii
2006-11-22 15:07 ` Chong Yidong
2006-11-22 22:20 ` Eli Zaretskii
2006-11-22 23:57 ` Nick Roberts
2006-11-23 4:12 ` Eli Zaretskii
2006-11-23 4:50 ` Nick Roberts
2006-11-24 18:18 ` Eli Zaretskii
2006-11-25 1:53 ` YAMAMOTO Mitsuharu
2006-11-25 4:18 ` Chong Yidong
2006-11-25 7:28 ` YAMAMOTO Mitsuharu
2006-11-25 10:53 ` Eli Zaretskii
2006-11-25 16:18 ` Chong Yidong
2006-11-25 21:10 ` Eli Zaretskii
2006-11-26 19:05 ` Kim F. Storm [this message]
2006-12-26 2:26 ` Richard Stallman
2006-12-27 3:58 ` Bob Rogers
2006-12-27 21:16 ` Richard Stallman
2007-01-02 15:46 ` Kim F. Storm
2007-01-05 0:38 ` Michael Mauger
2007-01-19 15:33 ` Chong Yidong
2007-01-20 21:40 ` Stephen Berman
2007-01-21 14:36 ` Stephen Berman
2007-11-07 22:18 ` Stephen Berman
2007-01-23 16:28 ` John Paul Wallington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bqmum3kw.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
--cc=rogers-emacs@rgrjr.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.