From: joakim@verona.se
To: Ken Brown <kbrown@cornell.edu>
Cc: Angelo Graziosi <angelo.graziosi@alice.it>,
Andreas Schwab <schwab@linux-m68k.org>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: ImageMagick support on Cygwin
Date: Mon, 23 Aug 2010 15:56:07 +0200 [thread overview]
Message-ID: <m3bp8t4emg.fsf@verona.se> (raw)
In-Reply-To: <4C727B9E.50407@cornell.edu> (Ken Brown's message of "Mon, 23 Aug 2010 09:46:06 -0400")
Ken Brown <kbrown@cornell.edu> writes:
> On 8/23/2010 8:48 AM, joakim@verona.se wrote:
>> Angelo Graziosi<angelo.graziosi@alice.it> writes:
>>
>>> Il 23/08/2010 14.07, joakim@verona.se ha scritto:
>>>> Angelo Graziosi<angelo.graziosi@alice.it> writes:
>>>>
>>>>> Il 23/08/2010 12.51, joakim@verona.se ha scritto:
>>>>>> Angelo Graziosi<angelo.graziosi@alice.it> writes:
>>>>>>
>>>>>>> Il 21/08/2010 8.55, joakim@verona.se ha scritto:
>>>>>>>> Angelo Graziosi<angelo.graziosi@alice.it> writes:
>>>>>>>>
>>>>>>>>> joakim wrote:
>>>>>>>>>> This analysis is probably correct. I'll try to check in a fix.
>>>>>>>>>
>>>>>>>>> Rev. 101149 still fails in the same manner. And these warnings
>>>>>>>>>
>>>>>>>>> [...]
>>>>>>>>> /tmp/emacs/src/image.c: In function ‘imagemagick_load_image’:
>>>>>>>>> /tmp/emacs/src/image.c:7663:11: warning: passing argument 2 of
>>>>>>>>> ‘PixelGetNextIteratorRow’ from incompatible pointer type [enabled by
>>>>>>>>> default]
>>>>>>>>> /usr/include/ImageMagick/wand/pixel-iterator.h:55:5: note: expected
>>>>>>>>> ‘long unsigned int *’ but argument is of type ‘size_t *’
>>>>>>>>> /tmp/emacs/src/image.c:7715:7: warning: implicit declaration of
>>>>>>>>> function ‘MagickExportImagePixels’ [-Wimplicit-function-declaration]
>>>>>>>>> /tmp/emacs/src/image.c: In function ‘Fimagemagick_types’:
>>>>>>>>> /tmp/emacs/src/image.c:7835:3: warning: passing argument 2 of
>>>>>>>>> ‘GetMagickList’ from incompatible pointer type [enabled by default]
>>>>>>>>> /usr/include/ImageMagick/magick/magick.h:87:5: note: expected ‘long
>>>>>>>>> unsigned int *’ but argument is of type ‘size_t *’
>>>>>>>>> [...]
>>>>>>>>>
>>>>>>>>> are not too reassuring...
>>>>>>>>
>>>>>>>> I'll try to set up a cygwin environment here. That will take a while.
>>>>>>>
>>>>>>> Sorry, but this issue is not Cygwin specific at all: I think you
>>>>>>> should setup also a GNU/Linux Kubuntu 8.04 system, on which there are
>>>>>>> the *same* identical problems that occur on Cygwin. On K804
>>>>>>> imagemagick is 6.3.7.
>>>>>>
>>>>>> Ok, I will download a vbox image and set up ubuntu 8.04.
>>>>>>
>>>>>> BTW the warnings seem to stem from some api change. I'll figure out some
>>>>>> solution for that also.
>>>>>
>>>>> The main problem is that bootstrap fails because the 'logic' in
>>>>> configure.in looks wrong in any case, as pointed out by Ken.
>>>>>
>>>>> If on Kubuntu 10.04 (the last Kubuntu) the bootstrap works, it happens
>>>>> _ONLY_ because the ImageMagick is more recent and, accidentally, has
>>>>> MagickExport.. defined.
>>>>
>>>> Does bootstrap fail even if you dont --enable-imagemagick?
>>>
>>> The bootstrap DOES NOT fail if:
>>>
>>> 1. imagemagick support is disabled, i.e. if one DOES NOT add
>>> --with-imagemagick' to configure
>>>
>>> 2. if 'AC_DEFINE(HAVE_MAGICKEXPORTIMAGEPIXELS, 0, [Define to 1 if
>>> MagickExportImagePixels is defined.])' is removed by configure.in and
>>> configure is regenereated (calling autoconf)
>>
>>
>> Thanks for this clarification.
>>
>>> It seems I am repeating my self or you do not read carefully what me
>>> and Ken are writing...
>>
>> Sorry, I have only limited powers of comprehension.
>>
>> Anyway, I have pushed a patch that removes the AC_DEFINE to the
>> imagemagick branch, and tested it on my development environment. I will
>> merge this fix to trunk in a while.
>
> It looks like Andreas has already done this (r 101171).
Yes, I noticed. Thanks Andreas!
>
> Ken
>
--
Joakim Verona
next prev parent reply other threads:[~2010-08-23 13:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 22:49 ImageMagick support on Cygwin Angelo Graziosi
2010-08-19 23:00 ` Angelo Graziosi
2010-08-20 9:01 ` Eli Zaretskii
2010-08-20 11:53 ` Ken Brown
2010-08-20 12:40 ` joakim
2010-08-20 14:34 ` Angelo Graziosi
2010-08-20 22:24 ` Angelo Graziosi
2010-08-21 6:55 ` joakim
2010-08-21 11:08 ` Ken Brown
2010-08-21 12:40 ` Angelo Graziosi
2010-08-23 10:00 ` Angelo Graziosi
2010-08-23 10:51 ` joakim
2010-08-23 11:33 ` Angelo Graziosi
2010-08-23 12:07 ` joakim
2010-08-23 12:16 ` Angelo Graziosi
2010-08-23 12:48 ` joakim
2010-08-23 13:46 ` Ken Brown
2010-08-23 13:56 ` joakim [this message]
2010-08-23 22:05 ` Angelo Graziosi
2010-08-24 6:04 ` joakim
-- strict thread matches above, loose matches on Subject: below --
2010-08-19 15:34 Angelo Graziosi
2010-08-19 18:10 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bp8t4emg.fsf@verona.se \
--to=joakim@verona.se \
--cc=angelo.graziosi@alice.it \
--cc=emacs-devel@gnu.org \
--cc=kbrown@cornell.edu \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.