From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#2553: *vc-diff* buffers are read-only, but M-k works Date: Sun, 11 Sep 2011 23:46:36 +0200 Message-ID: References: <87k575jnwl.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1315778157 22131 80.91.229.12 (11 Sep 2011 21:55:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 11 Sep 2011 21:55:57 +0000 (UTC) Cc: 2553@debbugs.gnu.org, emacs-devel@gnu.org, David Reitter To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 11 23:55:52 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R2s0G-0000bC-4O for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Sep 2011 23:55:52 +0200 Original-Received: from localhost ([::1]:46774 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2s0F-00058X-OH for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Sep 2011 17:55:51 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:42859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2s0C-000573-MZ for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2011 17:55:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R2s0B-0006cL-5d for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2011 17:55:48 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2s0A-0006cA-Vu for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2011 17:55:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R2s4K-00064N-A4; Sun, 11 Sep 2011 18:00:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2011 22:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 2553 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 2553-submit@debbugs.gnu.org id=B2553.131577836323213 (code B ref 2553); Sun, 11 Sep 2011 22:00:04 +0000 Original-Received: (at 2553) by debbugs.gnu.org; 11 Sep 2011 21:59:23 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2s3e-00062I-Qj for submit@debbugs.gnu.org; Sun, 11 Sep 2011 17:59:23 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2s3Y-00061m-Fj for 2553@debbugs.gnu.org; Sun, 11 Sep 2011 17:59:19 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R2rzH-0001x6-8j; Sun, 11 Sep 2011 23:54:51 +0200 In-Reply-To: <87k575jnwl.fsf@cyd.mit.edu> (Chong Yidong's message of "Wed, 04 Mar 2009 10:41:46 -0500") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Alasdair Roberts's _Spoils_: "So Bored Was I (Dark Triad)" X-MailScanner-ID: 1R2rzH-0001x6-8j MailScanner-NULL-Check: 1316382891.51326@ghv0xpd9GUmPmdSUEo1VfA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 11 Sep 2011 18:00:04 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51009 Archived-At: Chong Yidong writes: > The purpose of making the vc-diff buffer read-only (2007-11-10 change to > vc.el) was so that people can use the read-only diff-mode bindings like > "k" and "p". However, it's counter-intuitive that undo does not work. > Probably the easiest fix is to define a diff-undo command that lifts the > read-only restriction temporarily. Any thoughts? Perhaps a more general solution would be possible here. I think there probably are other "mostly-read-only" modes where you have one or two special commands that alter the buffer, anyway. Like with `M-k'. Perhaps there could be a buffer-local variable like `undo-read-only-buffer' that if set, would allow `undo' to work in these cases. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/