all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 2553@debbugs.gnu.org, emacs-devel@gnu.org,
	David Reitter <david.reitter@gmail.com>
Subject: bug#2553: *vc-diff* buffers are read-only, but M-k works
Date: Sun, 11 Sep 2011 23:46:36 +0200	[thread overview]
Message-ID: <m3bouqhhvn.fsf__22624.546432826$1315778157$gmane$org@stories.gnus.org> (raw)
In-Reply-To: <87k575jnwl.fsf@cyd.mit.edu> (Chong Yidong's message of "Wed, 04 Mar 2009 10:41:46 -0500")

Chong Yidong <cyd@stupidchicken.com> writes:

> The purpose of making the vc-diff buffer read-only (2007-11-10 change to
> vc.el) was so that people can use the read-only diff-mode bindings like
> "k" and "p".  However, it's counter-intuitive that undo does not work.
> Probably the easiest fix is to define a diff-undo command that lifts the
> read-only restriction temporarily.  Any thoughts?

Perhaps a more general solution would be possible here.  I think there
probably are other "mostly-read-only" modes where you have one or two
special commands that alter the buffer, anyway.  Like with `M-k'.
Perhaps there could be a buffer-local variable like
`undo-read-only-buffer' that if set, would allow `undo' to work in these
cases.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





  parent reply	other threads:[~2011-09-11 21:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04 15:41 *vc-diff* buffers are read-only, but M-k works Chong Yidong
2009-03-04 15:54 ` Juanma Barranquero
2009-03-04 15:54 ` bug#2553: " Juanma Barranquero
2011-09-11 21:46 ` Lars Magne Ingebrigtsen [this message]
2011-09-11 21:46 ` Lars Magne Ingebrigtsen
2011-09-13  1:26   ` Stefan Monnier
2011-10-06 21:59     ` bug#2553: " Lars Magne Ingebrigtsen
2011-10-06 21:59     ` Lars Magne Ingebrigtsen
2011-09-13  1:26   ` Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2009-03-04 15:41 Chong Yidong
2009-03-03  4:18 David Reitter
2012-04-26  3:33 ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='m3bouqhhvn.fsf__22624.546432826$1315778157$gmane$org@stories.gnus.org' \
    --to=larsi@gnus.org \
    --cc=2553@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=david.reitter@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.