From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: Deprecating BBDB 2.x support in EUDC for Emacs 26.1 Date: Sun, 29 Oct 2017 10:28:06 -0400 Message-ID: References: <83a80auroo.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1509287334 28837 195.159.176.226 (29 Oct 2017 14:28:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Oct 2017 14:28:54 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 29 15:28:49 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8oZt-0005qe-DH for ged-emacs-devel@m.gmane.org; Sun, 29 Oct 2017 15:28:41 +0100 Original-Received: from localhost ([::1]:36660 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8oZy-0003vp-VH for ged-emacs-devel@m.gmane.org; Sun, 29 Oct 2017 10:28:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8oZQ-0003vh-UA for emacs-devel@gnu.org; Sun, 29 Oct 2017 10:28:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8oZM-0004Ll-QR for emacs-devel@gnu.org; Sun, 29 Oct 2017 10:28:12 -0400 Original-Received: from mail-io0-x234.google.com ([2607:f8b0:4001:c06::234]:53177) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e8oZM-0004Ky-Ki for emacs-devel@gnu.org; Sun, 29 Oct 2017 10:28:08 -0400 Original-Received: by mail-io0-x234.google.com with SMTP id f20so21781964ioj.9 for ; Sun, 29 Oct 2017 07:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=svyxvzdmMNvGXWdf3FgbpaRqyPz3ziv0U1CRbqUYyB8=; b=xeHuc8FpdnpBCkx5fHg41BWniRz3TFSHSyCOXlRERuQO83buEYuoLVJJjcoB4Fnnr5 hM6MPqvLd7fz9+0f9/5I93XUhhlyScIsXqtzb51MrXe8EGUGGX2HEQaSKY0u2ZzIfi4j WwwZR+OVQNrIcsMA632vB+9Oo8GRYCKDnYUm3wrG4mHQeBeu6vcClWi9Rc4DkGY7H2gm zD8Wuj8HPQL5wkLSAPtZR/T1v9/5RuO94LbTb/qDKdC1z8nc6wiRLdeBnqA/ASuV3iEm 9fkcXQe32UBJe9ft6GFv77JoQK35VHp4nwcLKvuerkHBQeoC6irH3tKNV/bECr57BbHI Osrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=svyxvzdmMNvGXWdf3FgbpaRqyPz3ziv0U1CRbqUYyB8=; b=i1wBkSMKB9K3XCwxWxyL4JIsyjFGBWMO1mq3fEYC+fhxC4ksa0c19BDIxSFrmcEwuM VC7h7tcogeGl+e07/xTSYgPUYe23618YpIJniQIO0Ryau7wvw6rlN5UUCoPR5A44z9DM P1n2AEyABnfY/V9ukku8tfOvr5b+sjpLrHZTEfncE/M9HH76eKpCop98Uxk2rAX8ay0q 8alNZI0oX4iAIyYluHsCtJeVvlnIXcDto+hcZhRWBcJdjmGkmzSTePsWA4GgZYF0b0J6 LmGxkRAHau2vPXCLI2YTcAWfGSf2zd1MlgsuFi2ecwoFsKIPtv9o4uKyioFWOQ0nTGpw XseQ== X-Gm-Message-State: AMCzsaWg7p6+UKliyz2AqAyaAmFJw1FWF/RlZrFcjkemIcVi56pLAWHo /IgMxGZbIflO0nseYcTkFZrPjkNH X-Google-Smtp-Source: ABhQp+TKG/vv4pmUdqOGIBgYURUKF6Tqd4iWoriFvRop4mOyJ67kAkP+6ug25P31yTc9nQtFqVMBLg== X-Received: by 10.36.43.68 with SMTP id h65mr2644365ita.65.1509287287643; Sun, 29 Oct 2017 07:28:07 -0700 (PDT) Original-Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id v203sm781264itf.33.2017.10.29.07.28.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Oct 2017 07:28:06 -0700 (PDT) In-Reply-To: <83a80auroo.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Oct 2017 13:19:51 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c06::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219816 Archived-At: Eli Zaretskii writes: >> From: Thomas Fitzsimmons >> Date: Sat, 28 Oct 2017 21:07:25 -0400 >> >> For EUDC in the Emacs 26.1 release, I'd like to deprecate backward >> compatibility support for BBDB versions less than 3, and then >> subsequently remove that support, maybe as soon as Emacs 27.1. Doing so >> would simplify eudcb-bbdb.el and allow it to take advantage of new >> features that Roland has been adding in BBDB 3.x, like UUIDs. >> >> We discussed this idea on the bbdb-user mailing list. So far, no one >> has objected, but I thought I would also ask here before pushing the >> NEWS patch. Does the attached NEWS patch look OK to push to the >> emacs-26 branch? > > Looks OK, thanks. Thanks for reviewing. Pushed. > Is it possible to mark some 2.x specific functions or variables > obsolete? The compatibility logic is in EUDC functions that will continue to exist. The only candidate is eudc--using-bbdb-3-or-newer-p, but that's an EUDC-private function so it's not that useful to mark as obsolete. There are some declare-function calls, to declare BBDB 2.x functions that are not currently part of Emacs. But they are used in code that hasn't been ported to BBDB 3.x yet. My plan there is to a) move core parts of BBDB 3.x into Emacs core to satisfy those requirements, and b) port the EUDC code to those new BBDB 3.x functions. Doing so will eliminate the need to declare functions that don't exist in Emacs. Those declarations were a necessary ugliness before BBDB's copyright issues were worked out. Thanks, Thomas