Re: Deprecating BBDB 2.x support in EUDC for Emacs 26.1

[Thomas Fitzsimmons <fitzsim@fitzsim.org>]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
>> Date: Sat, 28 Oct 2017 21:07:25 -0400
>> 
>> For EUDC in the Emacs 26.1 release, I'd like to deprecate backward
>> compatibility support for BBDB versions less than 3, and then
>> subsequently remove that support, maybe as soon as Emacs 27.1.  Doing so
>> would simplify eudcb-bbdb.el and allow it to take advantage of new
>> features that Roland has been adding in BBDB 3.x, like UUIDs.
>> 
>> We discussed this idea on the bbdb-user mailing list.  So far, no one
>> has objected, but I thought I would also ask here before pushing the
>> NEWS patch.  Does the attached NEWS patch look OK to push to the
>> emacs-26 branch?
>
> Looks OK, thanks.

Thanks for reviewing.  Pushed.

> Is it possible to mark some 2.x specific functions or variables
> obsolete?

The compatibility logic is in EUDC functions that will continue to
exist.  The only candidate is eudc--using-bbdb-3-or-newer-p, but that's
an EUDC-private function so it's not that useful to mark as obsolete.

There are some declare-function calls, to declare BBDB 2.x functions
that are not currently part of Emacs.  But they are used in code that
hasn't been ported to BBDB 3.x yet.

My plan there is to a) move core parts of BBDB 3.x into Emacs core to
satisfy those requirements, and b) port the EUDC code to those new BBDB
3.x functions.  Doing so will eliminate the need to declare functions
that don't exist in Emacs.  Those declarations were a necessary ugliness
before BBDB's copyright issues were worked out.

Thanks,
Thomas