From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Deprecating BBDB 2.x support in EUDC for Emacs 26.1
Date: Sun, 29 Oct 2017 10:28:06 -0400 [thread overview]
Message-ID: <m3bmkq3u6h.fsf@fitzsim.org> (raw)
In-Reply-To: <83a80auroo.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Oct 2017 13:19:51 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
>> Date: Sat, 28 Oct 2017 21:07:25 -0400
>>
>> For EUDC in the Emacs 26.1 release, I'd like to deprecate backward
>> compatibility support for BBDB versions less than 3, and then
>> subsequently remove that support, maybe as soon as Emacs 27.1. Doing so
>> would simplify eudcb-bbdb.el and allow it to take advantage of new
>> features that Roland has been adding in BBDB 3.x, like UUIDs.
>>
>> We discussed this idea on the bbdb-user mailing list. So far, no one
>> has objected, but I thought I would also ask here before pushing the
>> NEWS patch. Does the attached NEWS patch look OK to push to the
>> emacs-26 branch?
>
> Looks OK, thanks.
Thanks for reviewing. Pushed.
> Is it possible to mark some 2.x specific functions or variables
> obsolete?
The compatibility logic is in EUDC functions that will continue to
exist. The only candidate is eudc--using-bbdb-3-or-newer-p, but that's
an EUDC-private function so it's not that useful to mark as obsolete.
There are some declare-function calls, to declare BBDB 2.x functions
that are not currently part of Emacs. But they are used in code that
hasn't been ported to BBDB 3.x yet.
My plan there is to a) move core parts of BBDB 3.x into Emacs core to
satisfy those requirements, and b) port the EUDC code to those new BBDB
3.x functions. Doing so will eliminate the need to declare functions
that don't exist in Emacs. Those declarations were a necessary ugliness
before BBDB's copyright issues were worked out.
Thanks,
Thomas
next prev parent reply other threads:[~2017-10-29 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 1:07 Deprecating BBDB 2.x support in EUDC for Emacs 26.1 Thomas Fitzsimmons
2017-10-29 11:19 ` Eli Zaretskii
2017-10-29 14:28 ` Thomas Fitzsimmons [this message]
2017-10-29 19:48 ` Deprecating BBDB 2.x support [in EUDC] " Roland Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bmkq3u6h.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.