From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry Fishman Newsgroups: gmane.emacs.devel Subject: Re: "Warning: `save-excursion' defeated by `set-buffer'" madness Date: Sun, 14 Feb 2010 14:38:13 -0500 Message-ID: References: <20100212204057.GG27521@headley> <20100214001755.GA2289@headley> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1266205687 9230 80.91.229.12 (15 Feb 2010 03:48:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Feb 2010 03:48:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 15 04:48:05 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NgrwJ-00083I-Lz for ged-emacs-devel@m.gmane.org; Mon, 15 Feb 2010 04:48:04 +0100 Original-Received: from localhost ([127.0.0.1]:57433 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NgrwI-0003ZS-Ub for ged-emacs-devel@m.gmane.org; Sun, 14 Feb 2010 22:48:02 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ngl2F-0001ew-MH for emacs-devel@gnu.org; Sun, 14 Feb 2010 15:25:43 -0500 Original-Received: from [140.186.70.92] (port=44546 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ngl2E-0001eT-R1 for emacs-devel@gnu.org; Sun, 14 Feb 2010 15:25:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ngl2E-000611-6I for emacs-devel@gnu.org; Sun, 14 Feb 2010 15:25:42 -0500 Original-Received: from mwsmtp04oc.mail2world.com ([74.202.142.139]:1961 helo=mail2world.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ngl2E-00060s-0J for emacs-devel@gnu.org; Sun, 14 Feb 2010 15:25:42 -0500 Original-Received: from mail pickup service by mail2world.com with Microsoft SMTPSVC; Sun, 14 Feb 2010 11:38:34 -0800 auth-sender: bfishman@alum.rpi.edu Original-Received: from 71.51.78.171 unverified ([71.51.78.171]) by mwsmtp04oc.mail2world.com with Mail2World SMTP Server; Sun, 14 Feb 2010 11:38:32 -0800 In-Reply-To: (Stefan Monnier's message of "Sun, 14 Feb 2010 11:32:00 -0500") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1.92 (gnu/linux) X-OriginalArrivalTime: 14 Feb 2010 19:38:34.0004 (UTC) FILETIME=[4B6FB540:01CAADAD] X-detected-operating-system: by eggs.gnu.org: Windows 2000 SP4, XP SP1+ X-Mailman-Approved-At: Sun, 14 Feb 2010 22:47:56 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121125 Archived-At: Stefan Monnier writes: >>> > Is there any way I can get rid of these warnings globally? It's >>> > really annoying to have *Compile-Log* pop up every now and then. >>> I put the following in my .emacs file: >>> ;; Shut off compiler error pop-up warning about >>> ;; save-excursion defeated by set-buffer >>> (setq byte-compile-warnings '(not suspicious)) >> Oh, great, thanks! >> I knew there had to be a way... > > I really hope you did first report the warning to get it fixed. I > currently only know of one external package (BBDB) where this warnings > pops up like this, so if you're using BBDB, try to install a newer > version. You think a new version would help? The CVS head of BBDB still looks like it would generate the compiler warning. Not to mention w3m, w3, and possibly other packages used with Gnus, that I don't feel like scanning through at the moment. They are easy enough to find just using grep. I do report problems that I find to the appropriate developers. In this case the issue is not necessarily a true bug but more a statement about how the Emacs code should be written. It is not the kind of thing I feel I should be enforcing. If you can't get these things fixed upstream, why do you think I can? I did fix all of my own code, and the packages that I use that no longer had upstream support. I send an off-list message to =C5=A0t=C4=9Bp=C3=A1n because he did not seem= to be getting a reply from anyone on the list, and I thought it seemed cruel to have him suffer because the Emacs developers want to send an annoying message to the external package developers. There already had been discussion on the list about the issue, and I saw no value in going over it again. I just showed him what he wanted, which is how to shut off the message, which nobody else seemed to have posted to the list. I run repo versions of Emacs and the external Emacs packages that I use, when they are avaliable. In part it is in self defence. The development versions tend to be reliable, and when interfaces are changed it usually happens one at time, rather that all at once. This gives me an opportunity to fix them in my code. I do report bugs that I find (and patches if I can) to the upstream developers. If I just used releases, I would see multiple problems all at once, and have to go back through the development mailing list to figure out what to do, long after any discussion was over. I have too much of my own code for that approach to work. --=20 Barry Fishman